Update target platform to use 4.38 ibuild #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Thompson <[email protected]>
Contributor
Author
|
The tests for microprofile.ls are passing flawlessly locally, so I'm very confused why they're failing here. |
datho7561
added a commit
to datho7561/lsp4mp
that referenced
this pull request
Sep 19, 2025
- Updates the version of gradle used from 7.3 to 9.1.0 so that it can be imported using Java 21, which should fix two test cases that are faling on GitHub Actions (but not locally for me) - This requires updating the Quarkus version of the project, so that the updated Quarkus Gradle plugin can be used, since the older version of the Quarkus Gradle plugin doesn't work with Gradle 9.1.0 Requires eclipse-lsp4mp#505 Signed-off-by: David Thompson <[email protected]>
rgrunber
approved these changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
I think this should be fine since platform itself tends to be more stable, but just be aware that in eclipse-jdtls/eclipse.jdt.ls#3526 I opted to use the 4.37 release until at least M1 of 4.38 for stability.
datho7561
added a commit
to datho7561/lsp4mp
that referenced
this pull request
Sep 19, 2025
- Updates the version of gradle used from 7.3 to 9.1.0 so that it can be imported using Java 21, which should fix two test cases that are faling on GitHub Actions (but not locally for me) - This requires updating the Quarkus version of the project, so that the updated Quarkus Gradle plugin can be used, since the older version of the Quarkus Gradle plugin doesn't work with Gradle 9.1.0 Requires eclipse-lsp4mp#505 Signed-off-by: David Thompson <[email protected]>
datho7561
added a commit
that referenced
this pull request
Sep 19, 2025
- Updates the version of gradle used from 7.3 to 9.1.0 so that it can be imported using Java 21, which should fix two test cases that are faling on GitHub Actions (but not locally for me) - This requires updating the Quarkus version of the project, so that the updated Quarkus Gradle plugin can be used, since the older version of the Quarkus Gradle plugin doesn't work with Gradle 9.1.0 Requires #505 Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.