Conversation
…to avoid the copy of local context data. Motivation: Copying the local data of a duplicated context was introduced to duplicate a context and copy its local data in order to implement specific behavior such as the support of grpc context. This behavior is only necessary in Vert.x 5 and this change has been back-ported to Vert.x 4.x to provide a similar implementation of context locals. This behavior is unexpected for some users of this API and we should preserve the previous behavior by default. Changes: Context duplication does not anymore copy the local data of a context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Copying the local data of a duplicated context was introduced to duplicate a context and copy its local data in order to implement specific behavior such as the support of grpc context. This behavior is only necessary in Vert.x 5 and this change has been back-ported to Vert.x 4.x to provide a similar implementation of context locals.
This behavior is unexpected for some users of this API and we should preserve the previous behavior by default.
Changes:
Context duplication does not anymore copy the local data of a context.