Fix unstable QuicServerTest.testRebind#5942
Open
ahus1 wants to merge 1 commit intoeclipse-vertx:masterfrom
Open
Fix unstable QuicServerTest.testRebind#5942ahus1 wants to merge 1 commit intoeclipse-vertx:masterfrom
ahus1 wants to merge 1 commit intoeclipse-vertx:masterfrom
Conversation
Member
|
@ahus1 normally the HTTP server bound by this verticle should be automatically undeployed as it is registered against the verticle for being undeployed via a hook |
ahus1
force-pushed
the
is-5941-stabilize-QuicServerTest.testRebind
branch
from
9207070 to
e11a95c
Compare
Contributor
Author
OK, I wasn't aware of that automatic handling - it came to me as a surprise. I see that this is mentioned in the docs. As I wasn't able to reproduce the problem, I first enhanced the code to provide some additional information when this happens the next time. Please let me know if this is ok. BTW, the GitHub CI failed due to another problem, and I opened yet another unstable test case issue: #5952 |
ahus1
force-pushed
the
is-5941-stabilize-QuicServerTest.testRebind
branch
from
e11a95c to
6fb0e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5941
Motivation: Closing the server explicitly when the verticle is undeployed to avoid the "Bind Address already in use" error.
Let me know if this is a valid fix, or if the test was trying to test something else.