Skip to content

Fix unstable QuicServerTest.testRebind #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahus1 wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

Fix unstable QuicServerTest.testRebind #5942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions vertx-core/src/test/java/io/vertx/tests/net/quic/QuicServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,8 +900,15 @@ public void testRebind() {
};
int num = 4;
for (int i = 0;i < num;i++) {
String id = vertx.deployVerticle(deployable).await();
vertx.undeploy(id).await();
try {
String id = vertx.deployVerticle(deployable).await();
// Undeploying the verticle is expected to close the QuicServer as it is bound to that context, see CleanableQuicServer
vertx.undeploy(id).await();
} catch (Exception e) {
// Show in which iteration it failed.
// If it fails in iteration 0, we know that another test didn't properly clean up.
throw new RuntimeException("failed in iteration " + i, e);
}
}
}

Expand Down
Loading