Skip to content

refactor: campaign subscriptions#1409

Merged
edgehog-app[bot] merged 1 commit intoedgehog-device-manager:mainfrom
ArnelaL:refactor-campaign-subcriptions
May 4, 2026
Merged

refactor: campaign subscriptions#1409
edgehog-app[bot] merged 1 commit intoedgehog-device-manager:mainfrom
ArnelaL:refactor-campaign-subcriptions

Conversation

@ArnelaL
Copy link
Copy Markdown
Collaborator

@ArnelaL ArnelaL commented May 4, 2026

refactor: campaign subscriptions

  • remove noop action on campaign resource that was used to trigger subscriptions when campaign target was updated
  • add subscriptions by campaign to campaign targets
  • update the frontend accordingly

What this PR does / why we need it:

Additional documentation e.g. usage docs, diagrams, reviewer notes, etc.:


Thanks for sending a pull request! If this is your first time, here are some tips for you:
  1. You can take a look at our developer guide for an introduction on Edgehog development!
  2. Make sure to read CONTRIBUTING.md and CODE_OF_CONDUCT.md
  3. If the PR is unfinished or you're actively working on it, mark it as draft

When fixing existing issues, use github's syntax to link your pull request to it

fixes #<issue number>

We also have a syntax to signal dependencies to other open pull requests

depends on #<pr number>
depends on https://github.com/...

In case of stacked PRs, you may add the PR number in the last commit's title instead:

gitGraph
    commit id: "Current master"
    branch feat1
    checkout feat1
    commit id: "feat: add something"
    commit id: "feat: add something else (#100)"
    branch feat2
    checkout feat2
    commit id: "refactor: do something"
    commit id: "fix: solve issue"
    commit id: "feat: add a feature (#101)"
    branch feat3
    checkout feat3
    commit id: "feat: feat without pr number"
Loading

- remove `noop` action on campaign resource that was used to trigger
subscriptions when campaign target was updated
- add subscriptions by campaign to campaign targets
- update the frontend accordingly

Signed-off-by: ArnelaL <arnela.lisic@secomind.com>
@ArnelaL ArnelaL force-pushed the refactor-campaign-subcriptions branch from 5339c49 to de0ccc8 Compare May 4, 2026 08:53
@ArnelaL ArnelaL requested review from OmarBrbutovic and lusergit May 4, 2026 08:53
Copy link
Copy Markdown
Collaborator

@OmarBrbutovic OmarBrbutovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lusergit
Copy link
Copy Markdown
Collaborator

lusergit commented May 4, 2026

🚀 /fast-forward

@edgehog-app edgehog-app Bot merged commit de0ccc8 into edgehog-device-manager:main May 4, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants