emdash/feat amp tokens day 5s9 by edmundmiller · Pull Request #49 · edmundmiller/dotfiles

edmundmiller · 2026-03-28T16:48:03Z

docs: add AGENTS.md for progressive context disclosure
docs: strip file-listing tables from AGENTS.md
docs(skills): replace static sources table with discovery hint
docs(skills): add nix flake metadata command for source discovery
docs: add agents-md-style rule, drop file table from rules/AGENTS.md
docs: add frontmatter example to agents-md-style rule
docs(rules): add YAML frontmatter with purpose to all rule files
docs(rules): add discovery command to rules/AGENTS.md

github-actions · 2026-03-28T16:48:17Z

🔍 PR Analysis

Category	Files Changed
Nix files	0
TypeScript files	0

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/dev/AGENTS.md
modules/editors/AGENTS.md

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

github-actions · 2026-03-28T22:23:13Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	0

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-28T22:36:41Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-28T22:51:33Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-28T23:28:14Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

devin-ai-integration

Devin Review found 1 new potential issue.

View 11 additional findings in Devin Review.

devin-ai-integration · 2026-03-28T23:32:33Z

+            base_sha="$(git rev-list --max-parents=0 HEAD)"
+          fi
+
+          mapfile -t nix_files < <(git diff --name-only "$base_sha" HEAD -- '*.nix')


🔴 statix CI step fails on PRs that delete .nix files

git diff --name-only "$base_sha" HEAD -- '*.nix' at line 44 includes deleted files in its output. When a PR deletes a .nix file, the filename is captured into nix_files, then the loop at line 51-53 runs statix check on a file that no longer exists on disk. Combined with set -euo pipefail at line 32, this causes the entire workflow step to fail with a non-zero exit code. The fix is to exclude deleted files, e.g. using --diff-filter=d (lowercase d excludes deletions).

Suggested change

mapfile -t nix_files < <(git diff --name-only "$base_sha" HEAD -- '*.nix')

mapfile -t nix_files < <(git diff --name-only --diff-filter=d "$base_sha" HEAD -- '*.nix')

Was this helpful? React with 👍 or 👎 to provide feedback.

github-actions · 2026-03-28T23:45:32Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:01:01Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

devin-ai-integration

Devin Review found 1 new potential issue.

View 15 additional findings in Devin Review.

devin-ai-integration · 2026-03-29T00:05:12Z

🔴 ctrl-d fzf binding uses bare tmux instead of resolved $TMUX_BIN

The PR's intent is to resolve binary paths for minimal PATH environments (e.g., tmux display-popup). All tmux invocations in sesh-picker.sh were updated to use $TMUX_BIN, but the ctrl-d fzf bind at line 70 still uses bare tmux kill-session. The fzf execute() action runs in a subprocess with the same minimal PATH, so tmux won't be found — the kill-session command will silently fail (or error) when the user presses ctrl-d to kill a session.

Was this helpful? React with 👍 or 👎 to provide feedback.

github-actions · 2026-03-29T00:17:44Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:25:12Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:31:50Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:36:57Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:41:52Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:48:35Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T00:58:07Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T01:03:40Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

github-actions · 2026-03-29T01:10:08Z

🔍 PR Analysis

Category	Files Changed
Nix files	2
TypeScript files	2

⚠️ Rebuild required — Nix files changed. Run hey re after merge.

Changed modules:

modules/AGENTS.md
modules/desktop/AGENTS.md
modules/services/hass/_domains/modes.nix

devin-ai-integration Bot reviewed Mar 28, 2026

View reviewed changes

edmundmiller force-pushed the emdash/feat-amp-tokens-day-5s9 branch from 323467a to de5c0e9 Compare March 28, 2026 22:23

edmundmiller force-pushed the emdash/feat-amp-tokens-day-5s9 branch from de5c0e9 to 1fe739a Compare March 28, 2026 22:36

fix: make CI hooks and tests pass

81a2265

edmundmiller force-pushed the emdash/feat-amp-tokens-day-5s9 branch from 1fe739a to 81a2265 Compare March 28, 2026 22:51

edmundmiller added 2 commits March 28, 2026 18:26

fix: clean flake and zunit temp dir

9d2d086

ci: scope statix to changed files

44c1b9c

devin-ai-integration Bot reviewed Mar 28, 2026

View reviewed changes

fix: bash-wrap sesh zunit invocations

12c522b

fix: tmux fallback in sesh scripts

1e120db

devin-ai-integration Bot reviewed Mar 29, 2026

View reviewed changes

fix: tmux/zoxide fallback

42fafb1

test: bash-path zunit mocks

02030d6

fix: tmux/zoxide ci paths

cd80b5d

fix: invoke tmux scripts via bash

ed36f85

test: pass bash path to zunit mocks

7f4c607

test: call zunit mocks with absolute bash

0138fae

This comment was marked as resolved.

Sign in to view

fix: pure-bash sesh zoxide paths

cace114

edmundmiller force-pushed the emdash/feat-amp-tokens-day-5s9 branch from 6b81088 to cace114 Compare March 29, 2026 01:03

ci: skip private nuc eval

cc94f89

edmundmiller merged commit a32a2d2 into main Mar 29, 2026
6 checks passed

	mapfile -t nix_files < <(git diff --name-only "$base_sha" HEAD -- '*.nix')
	mapfile -t nix_files < <(git diff --name-only --diff-filter=d "$base_sha" HEAD -- '*.nix')

Conversation

edmundmiller commented Mar 28, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 28, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

github-actions Bot commented Mar 29, 2026

🔍 PR Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

edmundmiller commented Mar 28, 2026 •

edited by devin-ai-integration Bot

Loading

devin-ai-integration Bot Mar 29, 2026 •

edited

Loading