-
Notifications
You must be signed in to change notification settings - Fork 6
emdash/feat amp tokens day 5s9 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
81a2265
9d2d086
44c1b9c
12c522b
1e120db
42fafb1
02030d6
cd80b5d
ed36f85
7f4c607
0138fae
cace114
cc94f89
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 ctrl-d fzf binding uses bare The PR's intent is to resolve binary paths for minimal PATH environments (e.g., tmux display-popup). All tmux invocations in Was this helpful? React with 👍 or 👎 to provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 statix CI step fails on PRs that delete .nix files
git diff --name-only "$base_sha" HEAD -- '*.nix'at line 44 includes deleted files in its output. When a PR deletes a.nixfile, the filename is captured intonix_files, then the loop at line 51-53 runsstatix checkon a file that no longer exists on disk. Combined withset -euo pipefailat line 32, this causes the entire workflow step to fail with a non-zero exit code. The fix is to exclude deleted files, e.g. using--diff-filter=d(lowercasedexcludes deletions).Was this helpful? React with 👍 or 👎 to provide feedback.