add link in toast to see pub in the library #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielweck
reviewed
Mar 21, 2025
src/renderer/library/components/searchResult/AllPublicationPage.tsx
Outdated
Show resolved
Hide resolved
danielweck
requested changes
Mar 21, 2025
| to={{ | ||
| ...location, | ||
| pathname: "/library", | ||
| search: `?focus=search&value=${this.props.publicationTitle}`, |
There was a problem hiding this comment.
This can match multiple publications, I wonder if we could be more specific? (uuid?)
danielweck
reviewed
Mar 21, 2025
src/renderer/library/components/searchResult/AllPublicationPage.tsx
Outdated
Show resolved
Hide resolved
When importing notes from the reader , the toast is displayed with "go to library" instead of focus to the reader window @danielweck @arthur-lemeur what do you think, we need to work on a better toast notification to not break the experience with too many distraction |
|
There is an another issue when importing notes/bookmark with the toast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.