Skip to content

add link in toast to see pub in the library [PR #2] !! #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

add link in toast to see pub in the library [PR #2] !! #2907

wants to merge 13 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Mar 24, 2025 •
edited
Loading

follow up this PR

@panaC panaC mentioned this pull request Mar 24, 2025
Merged
@danielweck danielweck self-requested a review April 16, 2025 08:58
danielweck
danielweck requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-16 at 09 58 43

@danielweck danielweck marked this pull request as draft April 16, 2025 09:01
@danielweck
Copy link
Member

Hello @panaC this reader window crash is reproducible 100%:

  1. open Thorium (library window)
  2. open EPUB
  3. come back to library
  4. optionally open a second EPUB (not necessary, but matches my screenshot below)
  5. drag and drop an EPUB on the library window (it doesn't matter if new publication or already imported)
  6. observe the crash in the displayed reader window(s)
Screenshot 2025-04-25 at 16 08 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck danielweck requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panaC @danielweck @arthur-lemeur