-
Notifications
You must be signed in to change notification settings - Fork 54
nHCal update to 24 mm scintillator #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
130 commits
Select commit
Hold shift + click to select a range
6a8f3db
Updated nHCal with segmentation based on STAR EEMC
lkosarz e22c942
Moved to other HcalEndcapN definitions
lkosarz b5e1f44
Placing fixed to HcalEndcapN
lkosarz b0cb821
Testing 12 bins in R (eta) for nHCal
lkosarz ef53f99
Merge branch 'main' of https://github.com/eic/epic.git into negative-…
lkosarz 5f97a5b
First try of extrapolating tlie sizes
lkosarz 11f5515
Updated extrapolated bins in R with a linear fit in eta
lkosarz fd739ee
Merge branch 'main' into negative-HCal-dev
wdconinc abe1c97
Update compact/definitions.xml
lkosarz d640e5b
Update compact/definitions.xml
lkosarz 0073189
Updated number of bins in phi from 36x6*deg to 60x6*deg
lkosarz 3cbf661
Merge branch 'negative-HCal-dev' of https://github.com/eic/epic.git i…
lkosarz 2b5abcf
fix: extend HcalEndcapN r segments to rmin/rmax
wdconinc b84a517
Shrink nHCal size to the segmentation limits
lkosarz b0c37f7
Merge branch 'master' into hcal-backward-segmentation-r
lkosarz 6c67e0b
Merge branch 'master' into negative-HCal-dev
lkosarz ef1052d
Merge branch 'hcal-backward-segmentation-r' into negative-HCal-dev
lkosarz c3b2710
Moved HcalEndcapN radii to hcal/hcal_backward.xml
lkosarz 6f270f5
Added HcalEndcapN_rmin and HcalEndcapN_rmax to segmentation limits
lkosarz a4961f9
Moved nHCal dimensions defintions to compact file
lkosarz ca2a745
Added missing comment
lkosarz bb57fe2
Fix issue #277 - error due to hits hitting nHCal corners
lkosarz 67e1157
Merge branch 'master' into hcal-backward-segmentation-r
lkosarz 6487285
Merge branch 'hcal-backward-segmentation-r'
lkosarz 623851d
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz f665d86
Change to CartesianGridXY 10cm*10cm segments
lkosarz 32c43e7
Merge branch 'master' into negative-HCal-dev
lkosarz a3133cd
Correct missing quotation marks
lkosarz fb16a33
Merge branch 'main' of https://github.com/eic/epic.git into negative-…
f56d6dc
Restored 10cm*10cm segmentation
870f351
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 97e3fe3
Fixed missing quotation marks
c8a1494
Merge branch 'negative-HCal-dev' of https://github.com/eic/epic.git i…
ac67dcb
Remove definitions.xml.orig
60391ad
Fix the zmin position of the nHCal with respect to service gap
lkosarz 98c9a1f
Smal fix
lkosarz f1bd1ba
Changed order
lkosarz e164a39
Fix nHCal position to the back and add a 64 cm gap behind service gap
lkosarz 87425b8
Merge branch 'nHCal-positionFix' of https://github.com/eic/epic.git i…
lkosarz dd544e0
Added backward endcap flux return steel (flux return, collar, oculus)
902fce4
Update name="FluxEndcapN_ID" to 117
391fd76
Corrected positions of flux return, collar and oculus
339d1c5
Adjusted mother endcapFlux mother volume to avoid overlaps
470aba4
Simplified the implementation - no overlaps.
45455f5
Merge branch 'main' into nHCal-positionFix
d5b8897
Moved flux return, collar and oculus dimensions to definitions
f3a0a28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0761d14
Removed detector ID for endcap flux return assembly
lkosarz c3bb87c
Merge branch 'nHCal-positionFix' of https://github.com/eic/epic.git i…
lkosarz 3359b93
Added missing SPDX license
c9acf14
Update compact/definitions.xml
lkosarz 5033d41
Update compact/display.xml
lkosarz db6c48f
Update compact/hcal/backward_endcap_flux.xml
lkosarz 6d5b4cd
Update src/EndcapFluxReturn_geo.cpp
lkosarz e78ad4a
Update src/EndcapFluxReturn_geo.cpp
lkosarz a817e2f
Removed namespace declarations
659de79
Changed FluxEndcapN_zpos -> FluxEndcapN_zshift
1cab5d9
Added endcap flux return to more configurations
4086214
Update src/EndcapFluxReturn_geo.cpp
lkosarz 94916d0
Update src/EndcapFluxReturn_geo.cpp
lkosarz c4228d8
Update src/EndcapFluxReturn_geo.cpp
lkosarz 9681f9d
Update src/EndcapFluxReturn_geo.cpp
lkosarz 29ac355
Update compact/hcal/backward_endcap_flux.xml
lkosarz 04b78e9
Update compact/display.xml
lkosarz c2dc5b2
Rotated sensitive volumes to offset rotation of assembly and segmenta…
lkosarz 891095f
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz a6e2087
Merge branch 'main' into nHCal-positionFix
lkosarz 920e850
added HCal only config
lkosarz 2322756
Fix transform
lkosarz e31a2eb
Rename hcal_only.yml to backward_hcal_only.yml
fead8bc
Merge branch 'main' of https://github.com/eic/epic.git
d717656
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz a6ed4be
Merge branch 'negative-HCal-dev'
lkosarz 027b209
Merge branch 'main' of https://github.com/eic/epic.git
2784154
Added switch for making all layers sensitive
7b6995c
Added allSensitive variable
5130acb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 77b8494
Update src/PolyhedraEndcapCalorimeter2_geo.cpp
lkosarz 393f3e6
Update src/PolyhedraEndcapCalorimeter2_geo.cpp
lkosarz f26eb8c
Added compact geometry as a template as requested
3f513f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 974632e
Update materials.xml
lkosarz b257c58
StainlessSteel -> StainlessSteelSAE304
veprbl 9daab76
Merge branch '884-stainlesssteel-density-fix-based-on-sae-304' of htt…
6930a40
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
1e4e0cd
Merge branch 'main' of https://github.com/eic/epic.git
02f8fa4
Merge branch 'main' into nHCal-dev-update
3e65368
Revert "StainlessSteel -> StainlessSteelSAE304"
veprbl 2237685
Revert "Update materials.xml"
veprbl 38b9a3f
Merge branch 'main' into nHCal-dev-update
veprbl 1deaf8d
Merge branch 'main' of https://github.com/eic/epic.git into nHCal-dev…
0d5531c
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
8cc3718
Update before merge with remote
bc775ae
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
bb6a40e
Revert mixed updates
0d82f17
Merge branch 'main' of https://github.com/eic/epic.git
3d1be7a
Merge branch 'main' into nHCal-dev-update
wdconinc edc7b86
Restore copyright header.
veprbl f71db84
Update year
veprbl 3491169
typo
veprbl 59431c2
Update compact/hcal/backward_sampF.xml
lkosarz fd12437
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz eb42949
Merge branch 'main' into nHCal-dev-update
lkosarz 2710675
Added nHCal using LFHCAL geometry
lkosarz 4146845
Fixed plate material setting to same as absorber
lkosarz 03be837
Implemented PCB offset
lkosarz 6e90943
Merge branch 'main' of https://github.com/eic/epic.git into nHCal-dev…
4715220
Merge branch 'main' of https://github.com/eic/epic.git
6b64f8c
Fixed missing param from constructors
768a22f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a556d11
Added nHCal specific variable names to avoid clash "HcalEndcapN_"
lkosarz a1d500b
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
lkosarz efbb860
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5c2ccd9
Updated info
lkosarz d2250a4
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
lkosarz 7a4e7ff
Reversed order of layers - correct!
lkosarz fae37b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d330993
Replace default with LFHCAL-type
lkosarz a302d73
Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…
lkosarz f09c123
Reverted change
lkosarz 3c27fc3
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz 0a6c937
Merge branch 'main' into nHCal-dev-update
lkosarz b1b970a
Changed geometry to 10x 4 cm steel and 24 mm plastic
lkosarz 15aff74
Removed endcap flux due to potential overlaps
lkosarz 59b9c8d
Merge branch 'main' of https://github.com/eic/epic.git
lkosarz 5c29863
Merge branch 'main' into nHCal-dev-update
lkosarz 9ed8f86
Revert to old LFHCAL constructor
lkosarz c7c5eb6
Removed extra files
lkosarz c1843e3
Renamed variables to use HcalEndcapN_length and add HcalEndcapN_exten…
lkosarz 2bd69c4
Merge branch 'main' into nHCal-dev-update-2025_11
veprbl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,3 @@ features: | |
| marco: | ||
| hcal: | ||
| backward_sampF: | ||
| backward_endcap_flux: | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.