Skip to content

fix some errors #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix some errors #115

wants to merge 1 commit into from

Conversation

bigplum
Copy link

@bigplum bigplum commented May 30, 2016

Fix some errors with multiple projects, if second project is empty:

  1. The ref will not be initial.
  2. Blame information will not shown.
  3. Fix Nonetype in commits.

@adam-waldenberg adam-waldenberg added this to the 0.4.5 milestone May 31, 2016
@adam-waldenberg adam-waldenberg self-assigned this May 31, 2016
@adam-waldenberg
Copy link
Member

Thank you. I actually think the NoneType in commits issue is related to the threading code.... I will investigate and merge your contribution once I have looked into it more.

@adam-waldenberg adam-waldenberg mentioned this pull request Jun 26, 2016
Closed
@carera
Copy link

carera commented Jun 26, 2016 •
edited
Loading

Checked this one out,
throws syntax error:

 File "gitinspector/gitinspector/changes.py", line 233
    else:
       ^
SyntaxError: invalid syntax

i guess the else expression is incorrectly indented

@bigplum
Copy link
Author

bigplum commented Jul 5, 2016

It may caused by the spaces intent in my code.

@adam-waldenberg
Copy link
Member

Going to take a look at this and also integrate parts of the pull request. A 0.4.5 release fixing this is most likely a good idea.

@adam-waldenberg adam-waldenberg modified the milestones: 0.5.0, 0.4.5 May 12, 2017
adam-waldenberg added a commit that referenced this pull request May 13, 2017
@adam-waldenberg
Handle git-rev-list and git-ls-tree with empty changesets (#132, #115).
a56680c 
If the changeset was empty or filtered with no matching files a bunch of
errors would be thrown from git with no proper results being returned
back to gitinspector.

We now pipe stderr (catching the output) and also check the return code
when running these commands.
@adam-waldenberg adam-waldenberg mentioned this pull request May 13, 2017
Closed
@adam-waldenberg
Copy link
Member

adam-waldenberg commented May 13, 2017 •
edited
Loading

@bigplum This got fixed now I believe. Solved using a slightly different solution with better error handling.

The issue with NoneType in commits can still happen, as there is a bug in the threading code. I will look into this. When the threading code is fixed this should (theoretically) never occur.

Let me know if any of the other issues still persists.

@adam-waldenberg adam-waldenberg mentioned this pull request May 13, 2017
Closed
adam-waldenberg added a commit that referenced this pull request May 15, 2017
@adam-waldenberg
Fix logic error in the threading code of the changes module (Fixes #118…
6d77989 
…).

This particular problem is also briefly mentioned in issue #115. The
fix resolves the overflow problem resulting in an array with a dangling
"None" type at the end. It also takes care of a race condition where
two threads by accident could update the same data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adam-waldenberg adam-waldenberg

Labels
Bug Priority : Medium
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bigplum @adam-waldenberg @carera