-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable ESM support for Node v20 #3469
Draft
trentm
wants to merge
2
commits into
main
Choose a base branch
from
trentm/esm-node20
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the hard work was done in import-in-the-middle#28. Refs: #3445
Also had to uninstall/reinstall some dev deps because `npm` was unable to resolve where to correctly place 'acorn' (which has usage of @8 and @7 by various other deps) and 'acorn-import-assertions' (which has a peerDep on acorn@8). This unforunately resulted in updating some transitive deps, so it muddies the package-lock change somewhat.
That fails the ESM test attempting to use
This is an import-in-the-middle issue, though I'm not exactly sure how tractable this will be in general. I've opened nodejs/import-in-the-middle#29 |
Note that we'll be updating to [email protected] in #3569 so this PR will need to be adjusted when we want to enable using node v20 and ESM. |
what is missing here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the hard work was done in import-in-the-middle#28.
Refs: #3445