-
Notifications
You must be signed in to change notification settings - Fork 5k
fix: add retry for listener creation in libbeat #46846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add retry for listener creation in libbeat #46846
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
d649ed0 to
c765b21
Compare
c765b21 to
1013925
Compare
a0936db to
a0eeec8
Compare
leehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: add retry for listener creation in libbeat * rename * context * remove deprecated * cleanup * cleanup * retry at API level instead of listener (cherry picked from commit 32b5e5a) # Conflicts: # x-pack/libbeat/cmd/instance/receiver.go
* fix: add retry for listener creation in libbeat * rename * context * remove deprecated * cleanup * cleanup * retry at API level instead of listener (cherry picked from commit 32b5e5a)
* fix: add retry for listener creation in libbeat * rename * context * remove deprecated * cleanup * cleanup * retry at API level instead of listener (cherry picked from commit 32b5e5a) Co-authored-by: Vihas Makwana <[email protected]>
…at (#46862) * fix: add retry for listener creation in libbeat (#46846) * fix: add retry for listener creation in libbeat * rename * context * remove deprecated * cleanup * cleanup * retry at API level instead of listener (cherry picked from commit 32b5e5a) # Conflicts: # x-pack/libbeat/cmd/instance/receiver.go * merge conflicts --------- Co-authored-by: Vihas Makwana <[email protected]> Co-authored-by: Vihas <[email protected]>
Proposed commit message
Similar to elastic/elastic-agent#10202.
Adds a retry mechanism when creating a named pipe listener on Windows.
Instead of failing immediately if listener creation fails, it now retries for up to 50 times with a short delay between attempts.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.