Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2025

Proposed commit message

Changes:

  • Refactor TestMultipleReceivers to easily scale to n>2 receivers
  • Clean up *.sock files
  • Add multiReceiverHelper struct to encapsulate receiver test setup
  • Add helper functions: hostFromSocket, writeFile
  • Use UUID for socket path generation instead of random bytes
  • Use DialContext instead of Dial to fix noctx lint warning

Pulled out from #47870 for easier review.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

Run the test

Related issues

## Proposed commit message
Changes:
- Refactor TestMultipleReceivers to easily scale to n>2 receivers
- Clean up *.sock files
- Add multiReceiverHelper struct to encapsulate receiver test setup
- Add helper functions: hostFromSocket, writeFile
- Use UUID for socket path generation instead of random bytes
- Use DialContext instead of Dial to fix noctx lint warning

Pulled out from #47870 for easier review.

(cherry picked from commit 135d04f)

# Conflicts:
#	x-pack/filebeat/fbreceiver/receiver_test.go
@mergify mergify bot requested a review from a team as a code owner December 9, 2025 14:27
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 9, 2025
@mergify mergify bot requested review from andrzej-stencel and khushijain21 and removed request for a team December 9, 2025 14:27
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Dec 9, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Dec 9, 2025

Cherry-pick of 135d04f has failed:

On branch mergify/bp/8.19/pr-47969
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 135d04f52.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x-pack/filebeat/fbreceiver/receiver_leak_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/filebeat/fbreceiver/receiver_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@orestisfl orestisfl enabled auto-merge (squash) December 9, 2025 14:50
@orestisfl orestisfl disabled auto-merge December 10, 2025 14:12
On Windows, open file handles prevent t.TempDir() cleanup.
Add defer f.Close() to properly release the file handle.

Fixes test failure introduced in #47969.
@orestisfl orestisfl merged commit b1413ea into 8.19 Dec 10, 2025
37 checks passed
@orestisfl orestisfl deleted the mergify/bp/8.19/pr-47969 branch December 10, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport cleanup conflicts There is a conflict in the backported pull request skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants