x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance by github-actions[bot] · Pull Request #50196 · elastic/beats

github-actions · 2026-04-17T14:07:49Z

Summary

add/adjusts BuildSystemTestBinary deprecation guidance

Why

Developers invoking mage BuildSystemTestBinary in x-pack/metricbeat were missing the migration guidance shown in other beats, creating inconsistent command UX.

Validation

attempted mage -l from x-pack/metricbeat but mage is not installed in this runner
compiled the package path with: go test -tags mage ./x-pack/metricbeat (the run was interrupted by environment module download constraints before completion)

Refs #50158

Fixes [ux-design-patrol] Inconsistent BuildSystemTestBinary deprecation guidance across magefiles #50158

What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Align x-pack/metricbeat BuildSystemTestBinary with the deprecation UX used in other magefiles so developers get consistent guidance when invoking the target.\n\nKeep the existing x-pack/metricbeat Windows-specific test binary build behavior and only add the deprecation doc comment plus warning output.\n\nAssisted-By: GitHub Copilot CLI\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

mergify · 2026-04-17T14:08:29Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @github-actions[bot]? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

This PR only adjusts deprecation guidance text and does not change user-facing behavior, so the changelog fragment is removed to align with skip-changelog policy. Assisted-By: GitHub Copilot CLI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-20T07:27:46Z

Done: I removed the changelog fragment and pushed the change to this PR branch.

I can’t set PR labels from the tools available in this run, so I wasn’t able to add skip-changelog directly. Please add that label on the PR, and it should satisfy the changelog requirement for this non-user-facing change.

What is this? | From workflow: Mention in PR

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Copilot

Pull request overview

This PR aligns x-pack/metricbeat’s mage UX with other beats by adding the standard BuildSystemTestBinary deprecation guidance (GoDoc Deprecated: comment + runtime warning) while preserving the existing x-pack metricbeat-specific build behavior.

Changes:

Mark BuildSystemTestBinary as deprecated via GoDoc Deprecated: guidance describing the TestMain behavior.
Print the standard deprecation warning message when BuildSystemTestBinary runs (consistent with other magefiles).
Keep the existing Windows 32-bit -ldflags=-w handling in the x-pack metricbeat-specific test binary build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Make BuildSystemTestBinary documentation and warning output consistent across all magefiles that define the target. Clarify that deprecation applies only to Go integration tests, while keeping the target positioned as required for Python system tests. Assisted-By: GPT-5.3-Codex Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-21T07:12:32Z

Updated and pushed.

I made the BuildSystemTestBinary deprecation docs and warning message consistent across all magefiles that define this target:

filebeat/magefile.go
libbeat/magefile.go
metricbeat/magefile.go
x-pack/filebeat/magefile.go
x-pack/libbeat/magefile.go
x-pack/metricbeat/magefile.go

The wording now explicitly states deprecation is for Go integration tests only, and that the target remains required for Python system tests.

I also resolved the two open review threads this addressed.

What is this? | From workflow: Mention in PR

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

…nary-guidance-3c178dbddb2050f8

AndersonQ · 2026-05-06T08:24:40Z

@cmacknz, @leehinman, @andrzej-stencel, when you have some time, could you review/re-review it?

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

AndersonQ · 2026-05-06T15:13:27Z

/ai adjust the PR description. the code has diverged from the original discretion.

github-actions · 2026-05-06T15:20:52Z

Updated PR description draft (aligned with the current diff):

Summary

normalizes BuildSystemTestBinary deprecation docs and warning text across all magefiles that define this target:
- filebeat/magefile.go:59-65
- libbeat/magefile.go:50-57
- metricbeat/magefile.go:66-73
- x-pack/filebeat/magefile.go:46-53
- x-pack/libbeat/magefile.go:38-45
- x-pack/metricbeat/magefile.go:112-124
standardizes wording to clarify this is deprecated for Go integration tests only, and that the target remains required for Python system tests
keeps x-pack/metricbeat’s existing Windows 32-bit -ldflags=-w build behavior unchanged (x-pack/metricbeat/magefile.go:119-122)

Why

The PR started as an x-pack/metricbeat UX consistency fix, but the branch now includes the same doc/warning normalization in five additional magefiles. This description reflects the full, current scope of the code changes.

Validation

reviewed the current PR diff and verified all six modified magefiles implement the same deprecation guidance pattern

Refs #50158

What is this? | From workflow: Mention in PR

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

AndersonQ · 2026-05-07T07:05:05Z

@cmacknz, @andrzej-stencel, @leehinman when you have some time, could you review it?

infra-vault-gh-plugin-prod · 2026-05-07T07:11:46Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

github-actions · 2026-05-14T11:40:41Z

@Mergifyio backport 9.4 9.3 8.19

mergify · 2026-05-14T11:43:19Z

backport 9.4 9.3 8.19

✅ Backports have been created

Details

#50696 [9.4](backport #50196) x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance has been created for branch 9.4
#50697 [9.3](backport #50196) x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance has been created for branch 9.3
#50698 [8.19](backport #50196) x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance has been created for branch 8.19

github-actions Bot added the ai label Apr 17, 2026

botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 17, 2026

AndersonQ reviewed Apr 20, 2026

View reviewed changes

Comment thread x-pack/metricbeat/magefile.go Outdated

AndersonQ reviewed Apr 20, 2026

View reviewed changes

Comment thread changelog/fragments/1776434430-x-pack-metricbeat-buildsystemtestbinary-deprecation.yaml Outdated

AndersonQ self-assigned this Apr 20, 2026

AndersonQ added backport-active-all Automated backport with mergify to all the active branches skip-changelog labels Apr 20, 2026

AndersonQ marked this pull request as ready for review April 20, 2026 10:25

AndersonQ requested a review from a team as a code owner April 20, 2026 10:25

AndersonQ requested review from andrzej-stencel, Copilot and leehinman April 20, 2026 10:25

Copilot started reviewing on behalf of AndersonQ April 20, 2026 10:26 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

cmacknz reviewed Apr 20, 2026

View reviewed changes

Comment thread x-pack/metricbeat/magefile.go Outdated

AndersonQ reviewed Apr 21, 2026

View reviewed changes

Comment thread x-pack/metricbeat/magefile.go Outdated

Comment thread x-pack/metricbeat/magefile.go Outdated

AndersonQ added 3 commits April 22, 2026 10:55

Merge branch 'main' into fix-50158-xpack-metricbeat-buildsystemtestbi…

c0ac87d

…nary-guidance-3c178dbddb2050f8

Merge branch 'main' into fix-50158-xpack-metricbeat-buildsystemtestbi…

bf638e0

…nary-guidance-3c178dbddb2050f8

Merge branch 'main' into fix-50158-xpack-metricbeat-buildsystemtestbi…

828f417

…nary-guidance-3c178dbddb2050f8

AndersonQ requested review from cmacknz and Copilot May 6, 2026 08:23

Copilot started reviewing on behalf of AndersonQ May 6, 2026 08:24 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread x-pack/metricbeat/magefile.go

Comment thread filebeat/magefile.go

pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 7, 2026

botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2026

andrzej-stencel approved these changes May 8, 2026

View reviewed changes

leehinman approved these changes May 11, 2026

View reviewed changes

andrzej-stencel merged commit 05a0a59 into main May 14, 2026
208 checks passed

andrzej-stencel deleted the fix-50158-xpack-metricbeat-buildsystemtestbinary-guidance-3c178dbddb2050f8 branch May 14, 2026 11:40

khushijain21 mentioned this pull request May 15, 2026

pipeline disconnect is now initalized by the beater #50721

Closed

6 tasks

Uh oh!

Conversation

github-actions Bot commented Apr 17, 2026 • edited by AndersonQ Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Validation

Uh oh!

mergify Bot commented Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

AndersonQ commented May 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

AndersonQ commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Summary

Why

Validation

Uh oh!

AndersonQ commented May 7, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 7, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

mergify Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Apr 17, 2026 •

edited by AndersonQ

Loading

mergify Bot commented May 14, 2026 •

edited

Loading