Skip to content

[9.3](backport #50196) x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance#50697

Open
mergify[bot] wants to merge 2 commits into
9.3from
mergify/bp/9.3/pr-50196
Open

[9.3](backport #50196) x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance#50697
mergify[bot] wants to merge 2 commits into
9.3from
mergify/bp/9.3/pr-50196

Conversation

@mergify

@mergify mergify Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

add/adjusts BuildSystemTestBinary deprecation guidance

Why

Developers invoking mage BuildSystemTestBinary in x-pack/metricbeat were missing the migration guidance shown in other beats, creating inconsistent command UX.

Validation

  • attempted mage -l from x-pack/metricbeat but mage is not installed in this runner
  • compiled the package path with: go test -tags mage ./x-pack/metricbeat (the run was interrupted by environment module download constraints before completion)

Refs #50158


What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.


This is an automatic backport of pull request #50196 done by [Mergify](https://mergify.com).

…0196)

* x-pack/metricbeat: add BuildSystemTestBinary deprecation guidance

Align x-pack/metricbeat BuildSystemTestBinary with the deprecation UX used in other magefiles so developers get consistent guidance when invoking the target.\n\nKeep the existing x-pack/metricbeat Windows-specific test binary build behavior and only add the deprecation doc comment plus warning output.\n\nAssisted-By: GitHub Copilot CLI\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove non-user-facing changelog fragment from PR

This PR only adjusts deprecation guidance text and does not change user-facing behavior, so the changelog fragment is removed to align with skip-changelog policy.

Assisted-By: GitHub Copilot CLI

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Align BuildSystemTestBinary deprecation wording

Make BuildSystemTestBinary documentation and warning output consistent across all magefiles that define the target. Clarify that deprecation applies only to Go integration tests, while keeping the target positioned as required for Python system tests.

Assisted-By: GPT-5.3-Codex

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 05a0a59)
@mergify mergify Bot requested a review from a team as a code owner May 14, 2026 11:44
@mergify mergify Bot added the backport label May 14, 2026
@mergify mergify Bot requested review from AndersonQ and orestisfl and removed request for a team May 14, 2026 11:44
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@github-actions github-actions Bot added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog ai labels May 14, 2026
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

TL;DR

golangci-lint failed only on lint (macos-latest) because the linter process hit its configured timeout (--timeout=30m) and exited with code 4, even though it reported 0 issues. Immediate action: re-run the failed job; this looks like a runtime timeout rather than a code-quality regression in this PR.

Remediation

  • Re-run the failed lint (macos-latest) job for this workflow run.
  • If it fails again with the same timeout, treat it as an infra/perf timeout and either (a) temporarily re-run until a healthy macOS runner is assigned or (b) raise the timeout budget/scope in the lint workflow for macOS runs.
Investigation details

Root Cause

The failing step is golangci-lint in the lint (macos-latest) job. The command ran with --timeout=30m and then terminated with Timeout exceeded, producing exit code 4.

Evidence

  • Workflow: https://github.com/elastic/beats/actions/runs/27018166891
  • Job/step: lint (macos-latest)golangci-lint
  • Key log excerpt:
    • Running [.../golangci-lint run ... --timeout=30m --whole-files]
    • level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
    • ##[error]golangci-lint exit with code 4
    • Ran golangci-lint in 2361846ms

Validation

  • Not run locally (read-only detective pass based on workflow logs).

Follow-up

  • If repeated on macOS only, this is likely runner performance variability rather than a PR-specific lint issue.

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant