[PoC] Add LogAsFilestream feature flag #143
Conversation
| google.protobuf.Struct source = 1; | ||
|
|
||
| FQDNFeature fqdn = 2; | ||
| FeatureFlag LogRunAsFilestream = 3; |
There was a problem hiding this comment.
Does this need to be here? Can't it flow in as part of the input/integration configuration? The reason FQDN is here is we wanted it supported for all agent components in the same policy, it is not input specific.
Additionally, because we include source here you could prototype or possibly even implement this by just parsing the new flag out of source which would transport it without this modification. It's the raw unmodified config from the features section of the agent policy.
There was a problem hiding this comment.
At the moment this flag is still in a PoC state, the current implementation forces all Log input to run as Filestream regardless of what has been set in the input configuration.
It is very useful for testing, allowing us to set it in the policy level without having to touch any integration. This covers both manual testing or actually deploying somewhere a snapshot version of the Elastic Agent/Beats and trying this out without having to update any integration.
Additionally, because we include source here you could prototype or possibly even implement this by just parsing the new flag out of source which would transport it without this modification. It's the raw unmodified config from the features section of the agent policy.
I'll try that later. Thanks!
Honestly, I wasn't expecting anyone to review a draft PR 😅. I created the PR mostly to easily link all the changes I'm making.
There was a problem hiding this comment.
I added [PoC] to the title to make it clear it's not a final implementation.
There was a problem hiding this comment.
I just wanted to make sure you weren't putting effort into something that isn't actually needed. I'm not taking this PR as the final implementation.
You don't need to touch the integration if it already accepted custom configuration where you can type whatever you want into the YAML box and have it be appended to the integration configuration.
I see value in having a global toggle at the policy level for this as a convenience but it does seem like something that is much easier to experiment with the integration level. That is probably also how we would want to roll it out, because we can change defaults in integrations at any time but changes to defaults for policy level settings require a stack release.
belimawr
changed the title
|
Closing this PR as there are other approaches to achieve the same result. |
2 participants
No description provided.