Skip to content

[PoC] Add LogAsFilestream feature flag #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
belimawr wants to merge 1 commit into from
Closed

[PoC] Add LogAsFilestream feature flag #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions elastic-agent-client.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,19 @@ message Features {
google.protobuf.Struct source = 1;

FQDNFeature fqdn = 2;
FeatureFlag LogRunAsFilestream = 3;
Copy link
Member

@cmacknz cmacknz Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be here? Can't it flow in as part of the input/integration configuration? The reason FQDN is here is we wanted it supported for all agent components in the same policy, it is not input specific.

Additionally, because we include source here you could prototype or possibly even implement this by just parsing the new flag out of source which would transport it without this modification. It's the raw unmodified config from the features section of the agent policy.

Copy link
Contributor Author

@belimawr belimawr Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment this flag is still in a PoC state, the current implementation forces all Log input to run as Filestream regardless of what has been set in the input configuration.

It is very useful for testing, allowing us to set it in the policy level without having to touch any integration. This covers both manual testing or actually deploying somewhere a snapshot version of the Elastic Agent/Beats and trying this out without having to update any integration.

Additionally, because we include source here you could prototype or possibly even implement this by just parsing the new flag out of source which would transport it without this modification. It's the raw unmodified config from the features section of the agent policy.

I'll try that later. Thanks!

Honestly, I wasn't expecting anyone to review a draft PR 😅. I created the PR mostly to easily link all the changes I'm making.

Copy link
Contributor Author

@belimawr belimawr Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added [PoC] to the title to make it clear it's not a final implementation.

Copy link
Member

@cmacknz cmacknz Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to make sure you weren't putting effort into something that isn't actually needed. I'm not taking this PR as the final implementation.

You don't need to touch the integration if it already accepted custom configuration where you can type whatever you want into the YAML box and have it be appended to the integration configuration.

I see value in having a global toggle at the policy level for this as a convenience but it does seem like something that is much easier to experiment with the integration level. That is probably also how we would want to roll it out, because we can change defaults in integrations at any time but changes to defaults for policy level settings require a stack release.

}

// FQDN feature flag indicates to use FQDN for host.name instead of hostname.
message FQDNFeature {
bool enabled = 1;
}

// FeatureFlag allows a feature flag to be enabled/disabled
message FeatureFlag {
bool enabled = 1;
}

// Elastic APM TLS config
message ElasticAPMTLS {
bool skip_verify = 1;
Expand Down
2 changes: 1 addition & 1 deletion pkg/proto/elastic-agent-client-deprecated.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/proto/elastic-agent-client-future.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/proto/elastic-agent-client-future_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading