Strip out seed from reproduce method name #121987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -Dtests.iters is used the test seed is appended to the method name by randomized runner. That in turn causes the reproduce line to contain the seed as part of the method name, which makes the reproduce line unuseable. This commit strips off any additional part of the method name before printing.
rjernst
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
smalyshev
reviewed
Feb 7, 2025
| @@ -61,6 +61,7 @@ public void testReplacePropertiesPlaceholderSystemProperty() { | |||
| .replacePropertyPlaceholders() | |||
| .build(); | |||
| assertThat(settings.get("setting1"), equalTo(value)); | |||
| fail("foo"); | |||
There was a problem hiding this comment.
should this part also be merged?
smalyshev
approved these changes
Feb 7, 2025
mark-vieira
reviewed
Feb 10, 2025
| if (methodName != null) { | ||
| // Method names only have spaces if used with -Dtests.iters where the seed is appended. | ||
| // Here we strip out anything from the first space, leaving the real method name intact. | ||
| methodName = methodName.split(" ")[0]; |
There was a problem hiding this comment.
I don't think this is the case. For things like YAML tests the names very often have spaces. This would then cause those repro lines to be corrupted.
There was a problem hiding this comment.
You're right, I had not considered parameterized tests. In fact, the seed is put into the same curly-braced section as parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -Dtests.iters is used the test seed is appended to the method name by randomized runner. That in turn causes the reproduce line to contain the seed as part of the method name, which makes the reproduce line unuseable. This commit strips off any additional part of the method name before printing.