Skip to content

Strip out seed from reproduce method name #121987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Strip out seed from reproduce method name #121987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0963fc5
Strip out seed from reproduce method name
rjernst Feb 7, 2025
6807a95
fix oops
rjernst Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions server/src/test/java/org/elasticsearch/common/settings/SettingsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public void testReplacePropertiesPlaceholderSystemProperty() {
.replacePropertyPlaceholders()
.build();
assertThat(settings.get("setting1"), equalTo(value));
fail("foo");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this part also be merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely not! removed

}

public void testReplacePropertiesPlaceholderSystemVariablesHaveNoEffect() {
Expand Down
5 changes: 4 additions & 1 deletion .../framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,11 @@ public void testFailure(Failure failure) throws Exception {
}
b.append(failure.getDescription().getClassName());

final String methodName = failure.getDescription().getMethodName();
String methodName = failure.getDescription().getMethodName();
if (methodName != null) {
// Method names only have spaces if used with -Dtests.iters where the seed is appended.
// Here we strip out anything from the first space, leaving the real method name intact.
methodName = methodName.split(" ")[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the case. For things like YAML tests the names very often have spaces. This would then cause those repro lines to be corrupted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I had not considered parameterized tests. In fact, the seed is put into the same curly-braced section as parameters.

// fallback to system property filter when tests contain "."
if (methodName.contains(".") || isBwcTest) {
b.append("\" -Dtests.method=\"");
Expand Down