[9.2] [SideNav] Warnings and slight initial render improvement (#239721)#240114
Merged
Conversation
) ## Summary - warnings fixes: - warn about duplicate ids in nav mapper - fix duplicate icons warning when icon is not a string - do not warn in prod - performance fixes: - mapper: - prevent unnecessary renders by separate navlinks update. we're not using them directly, so removed - add debounceTime(0) to prevent unnecessary re-render where one observable emits sync after another - ~nav (see videos before after)~ - ~reduce re-renders when resizing~ - ~reduce height remeasures when items height isn't expected to change. **helps with initial render in security**~ - moving to a separate pr ~I think with this we can close elastic#239331, because now tour in security opens reliably and I don't see initial flash anymore~ (cherry picked from commit 1d87f15)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @Dosant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation