[9.2] [Unified Data Table] Improve failing test speed (#243168)#245203
Merged
Conversation
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
## Summary Closes elastic#234829 Closes elastic#240905 Closes elastic#240904 All 3 tests were timing out so lets try to improve how fast they run - for this this PR changes from `get/queryByRole` to `get/queryByTestId` as it speeds up the tests significantly. Times measured isolating the tests using `it.only` and using the mean time of 10 runs + mean time of 10 runs of the whole file. > [!NOTE] > Both scripts to measure the test times were generated by ChatGPT Individual tests where measured with this script + `it.only`: [run-tests.sh](https://github.com/user-attachments/files/23580522/run-tests.sh) The whole test file was measured using this script: [all-tests.sh](https://github.com/user-attachments/files/23580737/all-tests.sh) | Test | Before | After | |--|--------|------| | should show the reset width button only for absolute width columns, and allow resetting to default width | 1268ms | 637ms | | should not reset the last column to auto width when there are remaining auto width columns | 894ms | 346ms | | should reset the last column to auto width if only absolute width columns remain | 893ms | 359ms | | All tests | 21.069s | 17.338s | ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 94c5602)
kibanamachine
force-pushed
the
backport/9.2/pr-243168
branch
from
d1a0b20 to
c4e7b05
Compare
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @AlexGPlay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation