Skip to content

[9.2] [Unified Data Table] Improve failing test speed (#243168) #245203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Dec 4, 2025
Merged

[9.2] [Unified Data Table] Improve failing test speed (#243168) #245203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ared/kbn-unified-data-table/src/components/__snapshots__/data_table_columns.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 14 additions & 22 deletions src/platform/packages/shared/kbn-unified-data-table/src/components/data_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,18 +1307,13 @@ describe('UnifiedDataTable', () => {
describe('columns', () => {
// Default column width in EUI is hardcoded to 100px for Jest envs
const EUI_DEFAULT_COLUMN_WIDTH = '100px';
const getColumnHeader = (name: string) => screen.getByRole('columnheader', { name });
const queryColumnHeader = (name: string) => screen.queryByRole('columnheader', { name });
const getColumnHeader = (name: string) => screen.getByTestId(`dataGridHeaderCell-${name}`);
const queryColumnHeader = (name: string) => screen.queryByTestId(`dataGridHeaderCell-${name}`);
const openColumnActions = async (name: string) => {
const actionsButton = screen.getByTestId(`dataGridHeaderCellActionButton-${name}`);
await userEvent.click(actionsButton);
await waitForEuiPopoverOpen();
};
const clickColumnAction = async (name: string) => {
const action = screen.getByRole('button', { name });
await userEvent.click(action);
};
const queryButton = (name: string) => screen.queryByRole('button', { name });

it(
'should reset the last column to auto width if only absolute width columns remain',
Expand All @@ -1336,7 +1331,7 @@ describe('UnifiedDataTable', () => {
expect(getColumnHeader('extension')).toHaveStyle({ width: '50px' });
expect(getColumnHeader('bytes')).toHaveStyle({ width: '50px' });
await openColumnActions('message');
await clickColumnAction('Remove column');
await userEvent.click(screen.getByTestId('unifiedDataTableRemoveColumn'));
await waitFor(() => {
expect(queryColumnHeader('message')).not.toBeInTheDocument();
});
Expand All @@ -1361,7 +1356,7 @@ describe('UnifiedDataTable', () => {
expect(getColumnHeader('extension')).toHaveStyle({ width: EUI_DEFAULT_COLUMN_WIDTH });
expect(getColumnHeader('bytes')).toHaveStyle({ width: '50px' });
await openColumnActions('message');
await clickColumnAction('Remove column');
await userEvent.click(screen.getByTestId('unifiedDataTableRemoveColumn'));
await waitFor(() => {
expect(queryColumnHeader('message')).not.toBeInTheDocument();
});
Expand All @@ -1384,24 +1379,21 @@ describe('UnifiedDataTable', () => {
},
});
expect(getColumnHeader('@timestamp')).toHaveStyle({ width: '50px' });

await openColumnActions('@timestamp');
await clickColumnAction('Reset width');
await waitFor(() => {
expect(getColumnHeader('@timestamp')).toHaveStyle({
width: `${defaultTimeColumnWidth}px`,
});
await userEvent.click(screen.getByTestId('unifiedDataTableResetColumnWidth'));
expect(getColumnHeader('@timestamp')).toHaveStyle({
width: `${defaultTimeColumnWidth}px`,
});

expect(getColumnHeader('message')).toHaveStyle({ width: EUI_DEFAULT_COLUMN_WIDTH });
await openColumnActions('message');
expect(queryButton('Reset width')).not.toBeInTheDocument();
await waitFor(() => {
expect(getColumnHeader('extension')).toHaveStyle({ width: '50px' });
});
expect(screen.queryByTestId('unifiedDataTableResetColumnWidth')).not.toBeInTheDocument();

expect(getColumnHeader('extension')).toHaveStyle({ width: '50px' });
await openColumnActions('extension');
await clickColumnAction('Reset width');
await waitFor(() => {
expect(getColumnHeader('extension')).toHaveStyle({ width: EUI_DEFAULT_COLUMN_WIDTH });
});
await userEvent.click(screen.getByTestId('unifiedDataTableResetColumnWidth'));
expect(getColumnHeader('extension')).toHaveStyle({ width: EUI_DEFAULT_COLUMN_WIDTH });
},
EXTENDED_JEST_TIMEOUT
);
Expand Down
1 change: 1 addition & 0 deletions src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ function buildEuiGridColumn({
defaultMessage: 'Remove column',
}),
iconType: 'cross',
'data-test-subj': 'unifiedDataTableRemoveColumn',
},
showMoveLeft: !defaultColumns,
showMoveRight: !defaultColumns,
Expand Down