Skip to content

[Agent Builder] Fix flakey test - conversation error handling - keeps the previous conversation rounds visible when there is an error#268383

Merged
chrisbmar merged 3 commits into
elastic:mainfrom
chrisbmar:ab-fix-flakey-test-268264
May 11, 2026
Merged

[Agent Builder] Fix flakey test - conversation error handling - keeps the previous conversation rounds visible when there is an error#268383
chrisbmar merged 3 commits into
elastic:mainfrom
chrisbmar:ab-fix-flakey-test-268264

Conversation

@chrisbmar
Copy link
Copy Markdown
Contributor

@chrisbmar chrisbmar commented May 8, 2026

Summary

closes #268264

Fixes a flakey test. Ensures that before we add any optimistic round, we cancel in-flight queries. Realistically a user would need to try to send a message <200ms after a response is received for this to be the case (impossible, they can't type that fast). But, guess who can type that fast? Robots in tests.

@chrisbmar chrisbmar self-assigned this May 8, 2026
@chrisbmar chrisbmar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels May 8, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12191

[✅] x-pack/platform/plugins/shared/agent_builder/test/scout_agent_builder/ui/playwright.config.ts (--arch stateful --domain classic): 50/50 tests passed.
[❌] x-pack/platform/plugins/shared/agent_builder/test/scout_agent_builder/ui/playwright.config.ts (--arch serverless --domain search): 45/50 tests passed.

see run history

@chrisbmar chrisbmar marked this pull request as ready for review May 8, 2026 12:19
@chrisbmar chrisbmar requested a review from a team as a code owner May 8, 2026 12:19
Copy link
Copy Markdown
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Dashboards Tab
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Logs Tab
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Metadata Tab
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Metrics Tab
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Open as page and return
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Overview Tab - KPI charts and collapsible sections
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Overview Tab - Services section
  • [job] [logs] Scout Lane #22 - serverless-observability_complete / default / local-serverless-observability_complete - Hosts Page - Flyout - Processes Tab
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is not setup and no data is loaded - Admin users
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is not setup and no data is loaded - Viewer users

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 1.1MB 1.1MB +49.0B

History

cc @chrisbmar

@chrisbmar chrisbmar merged commit 4787eff into elastic:main May 11, 2026
31 checks passed
clintandrewhall pushed a commit that referenced this pull request May 12, 2026
… the previous conversation rounds visible when there is an error (#268383)
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 13, 2026
… the previous conversation rounds visible when there is an error (elastic#268383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Agent Builder — conversation error handling - keeps the previous conversation rounds visible when there is an error

3 participants