Skip to content

[One Workflow] Fix Actions menu row layout after EUI 116 upgrade#271409

Merged
talboren merged 3 commits into
elastic:mainfrom
Kiryous:fix/workflows-actions-menu-eui116
May 31, 2026
Merged

[One Workflow] Fix Actions menu row layout after EUI 116 upgrade#271409
talboren merged 3 commits into
elastic:mainfrom
Kiryous:fix/workflows-actions-menu-eui116

Conversation

@Kiryous
Copy link
Copy Markdown
Contributor

@Kiryous Kiryous commented May 27, 2026

Closes https://github.com/elastic/security-team/issues/17599

Summary

EUI 116 (#260949) routes EuiSelectableListItem through the shared EuiListItemLayout (EUI #9532). The new layout (a) adds padding-block: 6px on .euiSelectableListItem__text and gap: 8px on .euiSelectableListItem__content, (b) drops the between-row border-bottom that EUI 114/115 set on every non-last item, and (c) shrinks the .euiSelectableList__groupLabel horizontal padding from 12px to 4px.

renderActionOption in the workflows Actions menu builds a custom icon + title + subtitle layout and owns its own spacing, so the new padding/gap stacked on top — rows grew from ~64 px to 76 px and the subtitle shifted. The dropped row border also broke the divider lines the design relies on, and the group label / header no longer sat on the same left edge as the items.

The fix scopes a few CSS overrides to the menu's EuiSelectable:

  • __content { gap: 0 }
  • __text { padding-block: 0 }
  • .euiSelectableListItem:not(:last-of-type) { border-bottom: thin } — restores the row divider
  • .euiSelectableList__groupLabel { padding-inline: 16px } — aligns "Add step" with the icon column
  • header { padding-inline: 16px } (was padding: 12px) — aligns the popover title and search with the items

Also gated the "Add step" group label on having at least one matching action, so searches with no step matches no longer leave an orphan label (matching the existing behavior of the Commands and Jump-to-a-step groups, per designer feedback).

After the fix, "Actions menu" title, search input, "Add step" label, and item icons all sit at the same x = 16 from the popover edge — matching the Figma design. Item height settles at 65 px with 1 px row borders.

Before / after

Current main (bug) With fix
before after

Empty search state

When a search has no matching steps, EuiSelectable's "doesn't match any options" message shows instead of an orphan "Add step" label:

empty

Test plan

  • Open the workflows YAML editor, press ⌘K, confirm rows are tight (~65 px), divider lines visible between items, subtitle sits directly under the title next to the icon
  • Confirm title, search input, "Add step" label, and item icons all sit at the same left edge
  • Click into a connector group (e.g. Triggers) — nested view renders the same way with dividers
  • Type Steps: to enter the virtualized full-catalog mode — items render correctly without overlapping
  • Type a query that doesn't match any step — confirm no orphan "Add step" label
  • No regression in the existing ActionsMenu Jest tests

@Kiryous Kiryous added Team:One Workflow Team label for One Workflow (Workflow automation) release_note:fix backport:version Backport to applied version labels v9.4.0 v9.4.1 labels May 27, 2026
@Kiryous Kiryous force-pushed the fix/workflows-actions-menu-eui116 branch from 1a24f2e to 2c38d28 Compare May 28, 2026 06:06
EUI 116 routes EuiSelectableListItem through the shared EuiListItemLayout,
which adds vertical padding on __text and a gap on __content.
renderActionOption owns its own spacing, so the new styles stacked on top
and inflated every row. Zero out the gap/padding to restore the row height.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Kiryous Kiryous force-pushed the fix/workflows-actions-menu-eui116 branch from 2c38d28 to 303a78b Compare May 28, 2026 06:22
@Kiryous Kiryous marked this pull request as ready for review May 28, 2026 09:18
@Kiryous Kiryous requested a review from a team as a code owner May 28, 2026 09:18
@Kiryous Kiryous self-assigned this May 28, 2026
Kiryous and others added 2 commits May 28, 2026 16:31
Per designer feedback, the "Add step" group label should only appear when
there are matching actions to show under it. The Commands and Jump-to-a-step
groups already follow this rule — apply the same gate to Add step in both
normal search and Steps: prefix mode.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #106 / Cloud Security Posture - Group 5 (KSPM + Flyouts) Security Alerts Page - Graph visualization expanded flyout - filter by node
  • [job] [logs] Scout Lane #2 - stateful-classic / default / local-stateful-classic - Query streams - Delete query stream - should support deleting an existing query stream
  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - UptimeIntegrationDeprecation - returns true when non-managed synthetics policies exist

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
workflowsManagement 2.5MB 2.5MB +246.0B

History

cc @Kiryous

@Kiryous Kiryous requested review from h88, shahargl and talboren May 29, 2026 20:54
Copy link
Copy Markdown
Contributor

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren merged commit 2a3780d into elastic:main May 31, 2026
31 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/26708107311

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
9.4 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 271409

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:fix Team:One Workflow Team label for One Workflow (Workflow automation) v9.4.0 v9.4.1 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants