[One Workflow] Fix Actions menu row layout after EUI 116 upgrade#271409
Merged
talboren merged 3 commits intoMay 31, 2026
Conversation
1a24f2e to
2c38d28
Compare
EUI 116 routes EuiSelectableListItem through the shared EuiListItemLayout, which adds vertical padding on __text and a gap on __content. renderActionOption owns its own spacing, so the new styles stacked on top and inflated every row. Zero out the gap/padding to restore the row height. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2c38d28 to
303a78b
Compare
Per designer feedback, the "Add step" group label should only appear when there are matching actions to show under it. The Commands and Jump-to-a-step groups already follow this rule — apply the same gate to Add step in both normal search and Steps: prefix mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
cc @Kiryous |
Contributor
|
Starting backport for target branches: 9.4 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/security-team/issues/17599
Summary
EUI 116 (#260949) routes
EuiSelectableListItemthrough the sharedEuiListItemLayout(EUI #9532). The new layout (a) addspadding-block: 6pxon.euiSelectableListItem__textandgap: 8pxon.euiSelectableListItem__content, (b) drops the between-rowborder-bottomthat EUI 114/115 set on every non-last item, and (c) shrinks the.euiSelectableList__groupLabelhorizontal padding from12pxto4px.renderActionOptionin the workflows Actions menu builds a custom icon + title + subtitle layout and owns its own spacing, so the new padding/gap stacked on top — rows grew from ~64 px to 76 px and the subtitle shifted. The dropped row border also broke the divider lines the design relies on, and the group label / header no longer sat on the same left edge as the items.The fix scopes a few CSS overrides to the menu's
EuiSelectable:__content { gap: 0 }__text { padding-block: 0 }.euiSelectableListItem:not(:last-of-type) { border-bottom: thin }— restores the row divider.euiSelectableList__groupLabel { padding-inline: 16px }— aligns "Add step" with the icon columnheader { padding-inline: 16px }(waspadding: 12px) — aligns the popover title and search with the itemsAlso gated the "Add step" group label on having at least one matching action, so searches with no step matches no longer leave an orphan label (matching the existing behavior of the Commands and Jump-to-a-step groups, per designer feedback).
After the fix, "Actions menu" title, search input, "Add step" label, and item icons all sit at the same
x = 16from the popover edge — matching the Figma design. Item height settles at 65 px with 1 px row borders.Before / after
Empty search state
When a search has no matching steps, EuiSelectable's "doesn't match any options" message shows instead of an orphan "Add step" label:
Test plan
⌘K, confirm rows are tight (~65 px), divider lines visible between items, subtitle sits directly under the title next to the iconSteps:to enter the virtualized full-catalog mode — items render correctly without overlappingActionsMenuJest tests