feat(fleet): replace title props and wrap EuiButtonIcon with EuiToolTip#271476
Open
weronikaolejniczak wants to merge 11 commits into
Open
feat(fleet): replace title props and wrap EuiButtonIcon with EuiToolTip#271476weronikaolejniczak wants to merge 11 commits into
weronikaolejniczak wants to merge 11 commits into
Conversation
8 tasks
weronikaolejniczak
added
backport:skip
alexwizp
added
backport:version
Contributor
|
/ci |
Contributor
Author
|
buildkite test this |
Comment on lines
+79
to
+85
| style={{ | ||
| borderTopLeftRadius: 0, | ||
| borderBottomLeftRadius: 0, | ||
| borderLeft: '1px solid rgba(255,255,255,0.3)', | ||
| height: 40, | ||
| minHeight: 0, | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
I would recommend migrating this to use @emotion/react instead of inline style. These are not dynamic and there's no reason to keep them inline. Also, is overriding this EuiButtonIcon even necessary? It can lead to more visual inconsistency in UI.
Contributor
Author
|
buildkite test this |
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
|
|
Pinging @elastic/eui-team (EUI) |
botelastic
Bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to elastic/eui#9566
Important
These changes should be carefully tested visually by each code owner. Wrapping with
EuiToolTipinstead of passingtitleleads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.This PR:
EuiButtonIconwithEuiToolTip, the content is the same asaria-label, anytitlepassed toEuiButtonIconis removed,titlecases (not truncation related) to useEuiToolTipinstead (if applicable).