Skip to content

feat(kibana-cloud-security-posture): replace title props and wrap EuiButtonIcon with EuiToolTip#271479

Open
weronikaolejniczak wants to merge 4 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-kibana-cloud-security-posture
Open

feat(kibana-cloud-security-posture): replace title props and wrap EuiButtonIcon with EuiToolTip#271479
weronikaolejniczak wants to merge 4 commits into
elastic:mainfrom
weronikaolejniczak:feat/replace-title-kibana-cloud-security-posture

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak commented May 27, 2026

Relates to elastic/eui#9566

Important

These changes should be carefully tested visually by each code owner. Wrapping with EuiToolTip instead of passing title leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.

This PR:

  • wraps ALL EuiButtonIcon with EuiToolTip, the content is the same as aria-label, any title passed to EuiButtonIcon is removed,
  • changes several title cases (not truncation related) to use EuiToolTip instead (if applicable).

@weronikaolejniczak weronikaolejniczak added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2026
@weronikaolejniczak
Copy link
Copy Markdown
Contributor Author

buildkite test this

@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review May 28, 2026 07:39
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner May 28, 2026 07:39
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/eui-team (EUI)

@alexwizp alexwizp added backport:version Backport to applied version labels v9.5.0 v9.4.2 and removed backport:skip This PR does not require backporting labels May 28, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #149 / Dashboard dashboard in space Storing search sessions in space Saves and restores a session

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudDefend 93.7KB 94.1KB +415.0B
kubernetesSecurity 228.3KB 228.3KB +17.0B
total +432.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels EUI release_note:skip Skip the PR/issue when compiling release notes v9.4.2 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants