Skip to content

feat(kibana-data-discovery, obs-exploration-team): replace title props and wrap EuiButtonIcon with EuiToolTip #271482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weronikaolejniczak wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −22
Open

feat(kibana-data-discovery, obs-exploration-team): replace title props and wrap EuiButtonIcon with EuiToolTip #271482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a360ce
feat(kibana-data-discovery, obs-exploration-team): replace title prop…
weronikaolejniczak May 27, 2026
9e54d36
Merge branch 'main' into feat/replace-title-kibana-data-discovery-obs…
alexwizp Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...bn-discover-contextual-components/src/data_types/logs/components/cell_actions_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ import type { ReactElement, ReactNode } from 'react';
import React, { useMemo } from 'react';
import {
EuiBadge,
type EuiBadgeProps,
EuiButtonEmpty,
EuiButtonIcon,
EuiCopy,
EuiFlexGroup,
EuiFlexItem,
EuiPopover,
EuiPopoverFooter,
EuiText,
EuiButtonIcon,
EuiButtonEmpty,
EuiCopy,
EuiToolTip,
type EuiBadgeProps,
useEuiTheme,
useGeneratedHtmlId,
} from '@elastic/eui';
Expand Down Expand Up @@ -124,14 +125,16 @@ export function CellActionsPopover({
</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
aria-label={closeCellActionPopoverText}
data-test-subj="dataTableExpandCellActionPopoverClose"
iconSize="s"
iconType="cross"
size="xs"
onClick={closePopover}
/>
<EuiToolTip content={closeCellActionPopoverText} disableScreenReaderOutput>
<EuiButtonIcon
aria-label={closeCellActionPopoverText}
data-test-subj="dataTableExpandCellActionPopoverClose"
iconSize="s"
iconType="cross"
size="xs"
onClick={closePopover}
/>
</EuiToolTip>
</EuiFlexItem>
</EuiFlexGroup>
{onFilter ? (
Expand Down
29 changes: 19 additions & 10 deletions ...er-contextual-components/src/data_types/logs/components/summary_column/summary_column.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@

import { DataGridDensity, type DataGridCellValueElementProps } from '@kbn/unified-data-table';
import React, { useMemo } from 'react';
import { EuiButtonIcon, EuiCodeBlock, EuiFlexGroup, EuiText, EuiTitle } from '@elastic/eui';
import {
EuiButtonIcon,
EuiCodeBlock,
EuiFlexGroup,
EuiText,
EuiTitle,
EuiToolTip,
} from '@elastic/eui';
import { JsonCodeEditor } from '@kbn/unified-doc-viewer-plugin/public';
import type { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
import type { CoreStart } from '@kbn/core-lifecycle-browser';
Expand Down Expand Up @@ -187,15 +194,17 @@ export const SummaryCellPopover = (props: AllSummaryColumnProps) => {

return (
<EuiFlexGroup direction="column" css={{ position: 'relative', width: 580 }}>
<EuiButtonIcon
aria-label={closeCellActionPopoverText}
data-test-subj="docTableClosePopover"
iconSize="s"
iconType="cross"
size="xs"
onClick={closePopover}
css={{ position: 'absolute', right: 0 }}
/>
<EuiToolTip content={closeCellActionPopoverText} disableScreenReaderOutput>
<EuiButtonIcon
aria-label={closeCellActionPopoverText}
data-test-subj="docTableClosePopover"
iconSize="s"
iconType="cross"
size="xs"
onClick={closePopover}
css={{ position: 'absolute', right: 0 }}
/>
</EuiToolTip>
{shouldRenderResource && (
<EuiFlexGroup direction="column" gutterSize="s">
<EuiTitle size="xxs">
Expand Down
Loading