feat(kibana-data-discovery, obs-exploration-team): replace title props and wrap EuiButtonIcon with EuiToolTip#271482
Conversation
…s and wrap EuiButtonIcon with EuiToolTip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
|
Pinging @elastic/eui-team (EUI) |
akowalska622
left a comment
There was a problem hiding this comment.
Code looks good and overall the change from EUI side is correct.
However I found some quirks which are probably on @elastic/obs-exploration-team side, I'd appreciate if they also take a look as co-owners.
The tooltip for summary column looks unnecessarily wide, which on smaller screens causes it to scroll. Firstly I thought there's no closing icon at all, but it was overflowed and obscured:
It also doesn't adjust if you resize window while having popover open.
After changes in this PR it causes even more quirky UI effects - even if you open popover on a bigger screen, the tooltip position looks way off:
I didn't dive very deep here, so I might be mistaken, but it seems like obs team is adding a fixed width here for the wrapper, which is not a very good practice and seems to be a root cause for the issue:
That being said, I'll leave the final approval to @elastic/obs-exploration-team
…-exploration-team
Relates to elastic/eui#9566
Important
These changes should be carefully tested visually by each code owner. Wrapping with
EuiToolTipinstead of passingtitleleads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.This PR:
EuiButtonIconwithEuiToolTip, the content is the same asaria-label, anytitlepassed toEuiButtonIconis removed,titlecases (not truncation related) to useEuiToolTipinstead (if applicable).