feat(kibana-security): replace title props and wrap EuiButtonIcon with EuiToolTip

[weronikaolejniczak]

Relates to elastic/eui#9566

Important

These changes should be carefully tested visually by each code owner. Wrapping with EuiToolTip instead of passing title leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.

This PR:

• wraps ALL EuiButtonIcon with EuiToolTip, the content is the same as aria-label, any title passed to EuiButtonIcon is removed,
• changes several title cases (not truncation related) to use EuiToolTip instead (if applicable).

[weronikaolejniczak]

buildkite test this

[infra-vault-gh-plugin-prod]

Pinging @elastic/eui-team (EUI)

[jeramysoucy]

Below is a matrix of changes to the Kibana Security domain. I have tested each case.

Surface	File	Change
Role Mappings → Field rule editor	field_rule_editor.tsx	Wrap "Add alternate value" (+) and "Delete value" (🗑) icon buttons in EuiToolTip. Add aria-hidden to empty filler icons.
Roles → Index privileges	index_privilege_form.tsx	Wrap "Delete index/remote-index privilege" (🗑) icon button in EuiToolTip.
Roles → Remote cluster privileges	remote_cluster_privileges_form.tsx	Wrap "Delete remote cluster privilege" (🗑) icon button in EuiToolTip.
Roles → Privilege summary table	privilege_summary_table.tsx	Wrap the row expand/collapse chevron button in EuiToolTip. Add aria-hidden to decorative category icons.
Roles → Kibana privileges → space table	privilege_space_table.tsx	Wrap "Edit" (✏️) and "Delete" (🗑) row-action icon buttons in EuiToolTip. Add aria-hidden to empty filler icon.
Copy to space → result details	space_result_details.tsx	Replace <p className="eui-textTruncate" title={name}> with <EuiTextTruncate text={name} />.
Space settings → solution view callout	solution_view_switch_callout_internal.tsx	Wrap the callout's "Dismiss" (×) icon button in EuiToolTip.
Space selector card	space_card.tsx	Replace title attribute on EuiTextColor description with a wrapping EuiToolTip.

[jeramysoucy]

It seems unnecessary to add the additional tooltip text here given the style of the button and the inclusion of aria-label, but I am not opposed to it either.

[weronikaolejniczak]

The tooltip is for sighted users to understand what this button does. aria-label allows screen readers to announce the button appropriately.

Our recommendation as EUI team: always wrap EuiButtonIcon with EuiToolTip and always pass aria-label to it.

[kibanamachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 2b7d1c6
• Build duration: 66 mins

Failed CI Steps

• FTR Configs #10
• FTR Configs #78
• FTR Configs #157
• FTR Configs #167
• FTR Configs #168
• FTR Configs #189

Test Failures

• [job] [logs] FTR Configs #168 / Cloud Security Posture POST /internal/cloud_security_posture/graph Happy flows Graph without data enrichment should return 200 when securitySolution:enableAssetInventory is true without enrich policy
• [job] [logs] FTR Configs #157 / Dashboard dashboard in space Storing search sessions in space Saves and restores a session

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
security	550.1KB	551.9KB	+1.8KB
spaces	252.6KB	252.8KB	+186.0B
total			+1.9KB

History

• 💔 Build #449595 failed 3002863
• 💛 Build #449045 was flaky 31bb290
• 💔 Build #448952 failed da69329