refactor(sig-events): remove verdicts data stream, merge audit fields into events#271626
Draft
crespocarlos wants to merge 11 commits into
Draft
refactor(sig-events): remove verdicts data stream, merge audit fields into events#271626crespocarlos wants to merge 11 commits into
crespocarlos wants to merge 11 commits into
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Co-authored-by: Cursor <cursoragent@cursor.com>
… and fix locale in formatters Co-authored-by: Cursor <cursoragent@cursor.com>
…d UI polish Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
9eee9e6 to
7b556f4
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
7b556f4 to
edb0bbd
Compare
8 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapses the
.significant_events-verdictsdata stream into.significant_events-events. Audit fields (verdict_summary,assessment_note,verdict_source,original_verdict,conversation_id,grouped_discovery_ids) are merged intosigEventSchemaandeventsMappings.The Verdicts tab and
use_fetch_verdictshook are removed fromstreams_app; lifecycle timeline and flyout now surface audit information from event documents only.How to test
verdict_summaryandassessment_noteappear on the event row when present, with noverdictssection.GET /internal/streams/{name}/sig_events/eventsandGET /internal/streams/{name}/sig_events/events/{id}/lifecyclerespond successfully;lifecycleresponse body contains{ detections, discoveries, events }only (noverdictskey).node scripts/type_checkforkbn-streams-schema,streams, andstreams_app.🤖 Co-authored with AI assistance.