Skip to content

refactor(sig-events): remove verdicts data stream, merge audit fields into events#271626

Draft
crespocarlos wants to merge 11 commits into
elastic:mainfrom
crespocarlos:1279-remove-verdicts
Draft

refactor(sig-events): remove verdicts data stream, merge audit fields into events#271626
crespocarlos wants to merge 11 commits into
elastic:mainfrom
crespocarlos:1279-remove-verdicts

Conversation

@crespocarlos
Copy link
Copy Markdown
Contributor

@crespocarlos crespocarlos commented May 28, 2026

Summary

Collapses the .significant_events-verdicts data stream into .significant_events-events. Audit fields (verdict_summary, assessment_note, verdict_source, original_verdict, conversation_id, grouped_discovery_ids) are merged into sigEventSchema and eventsMappings.

The Verdicts tab and use_fetch_verdicts hook are removed from streams_app; lifecycle timeline and flyout now surface audit information from event documents only.

How to test

  • Verify the Significant Events tab loads without errors and the Verdicts tab is absent.
  • Open the event lifecycle flyout for a reviewed discovery; confirm verdict_summary and assessment_note appear on the event row when present, with no verdicts section.
  • Confirm GET /internal/streams/{name}/sig_events/events and GET /internal/streams/{name}/sig_events/events/{id}/lifecycle respond successfully; lifecycle response body contains { detections, discoveries, events } only (no verdicts key).
  • Automated: type-check via node scripts/type_check for kbn-streams-schema, streams, and streams_app.

🤖 Co-authored with AI assistance.

@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!

@crespocarlos crespocarlos force-pushed the 1279-remove-verdicts branch 8 times, most recently from 9eee9e6 to 7b556f4 Compare May 30, 2026 21:28
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant