refactor(sig-events): rename verdict to status, simplify triage workflow#272036
Draft
crespocarlos wants to merge 13 commits into
Draft
refactor(sig-events): rename verdict to status, simplify triage workflow#272036crespocarlos wants to merge 13 commits into
crespocarlos wants to merge 13 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # x-pack/platform/plugins/shared/streams/server/agent_builder/register.ts # x-pack/platform/plugins/shared/streams/server/plugin.ts
…lows-and-agents-into-kibana
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
verdictterminology from the sig_events managed workflows and agent instructions, and simplifiestriage.yamlto the append-only events model.Workflow changes (primary):
triage.yaml: removes.significant_events-verdictsindex reference; deletes 4 dead existence-check steps (check_existing_event_doc,check_latest_verdict_doc,compute_changes,compute_write_gates) — unnecessary now that events is append-only; renames allVERDICT_*constants →STATUS_*, step names (store_verdicts→store_significant_events, etc.), and output key (verdicts→significant_events); adds audit fields to the event write body; removeswrite_verdict_docdiscovery.yaml:verdict→statusin all field references and filtersjudge.md.text/investigator.md.text: output field names, schema table, and evaluation guidance updatedTypeScript cascade (resolves TODOs left by #271626):
sigEventSchema:verdict→status;verdict_summary→analysis_summary;verdict_idremoved; audit fields added; data stream version bumped 4 → 5Depends on #271626 — must merge first; this PR should be rebased on main after that merges.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
verdict→status): existing rollover indices retainverdict; new indices usestatus. First triage cycle after deploy re-evaluates all pre-migration discoveries (one-time burst — expected, no data loss).lifecycle_timeline.tsxsilently drops verdict entries. Merge order matters.🤖 Co-authored with AI assistance.
Made with Cursor