Skip to content

[App Menu] Fix action button popover reposition #272011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kowalczyk-krzysztof wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

[App Menu] Fix action button popover reposition #272011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d758d0
[App Menu] Fix action button popover reposition
kowalczyk-krzysztof May 29, 2026
6f6801a
Merge branch 'main' into fix/app-menu-popover-button-axis
kowalczyk-krzysztof May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...chrome/app-menu/core-chrome-app-menu-components/src/components/app_menu_action_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ export const AppMenuActionButton = (props: AppMenuActionButtonProps) => {
popoverWidth={popoverWidth}
popoverTestId={popoverTestId}
anchorPosition="downRight"
repositionToCrossAxis={false}
onClose={onPopoverClose}
onCloseOverflowButton={onCloseOverflowButton}
/>
Expand All @@ -195,6 +196,7 @@ export const AppMenuActionButton = (props: AppMenuActionButtonProps) => {
popoverWidth={popoverWidth}
popoverTestId={popoverTestId}
anchorPosition="downRight"
repositionToCrossAxis={false}
onClose={onPopoverClose}
onCloseOverflowButton={onCloseOverflowButton}
/>
Expand Down
3 changes: 3 additions & 0 deletions ...kages/chrome/app-menu/core-chrome-app-menu-components/src/components/app_menu_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ interface AppMenuContextMenuProps {
switchConfig?: AppMenuSwitch;
popoverTestId?: string;
anchorPosition?: PopoverAnchorPosition;
repositionToCrossAxis?: boolean;
onClose: () => void;
onCloseOverflowButton?: () => void;
}
Expand All @@ -47,6 +48,7 @@ export const AppMenuPopover = ({
switchConfig,
popoverTestId = 'app-menu-popover',
anchorPosition = 'downLeft',
repositionToCrossAxis,
onClose,
onCloseOverflowButton,
}: AppMenuContextMenuProps) => {
Expand Down Expand Up @@ -100,6 +102,7 @@ export const AppMenuPopover = ({
hasArrow={false}
anchorPosition={anchorPosition}
aria-label={title || content}
repositionToCrossAxis={repositionToCrossAxis}
>
<EuiContextMenu initialPanelId={0} panels={panels} css={{ minWidth: 180 }} />
</EuiPopover>
Expand Down
Loading