[Entity Store] Remove duplicate extraction error log to reduce alert noise#272047
Open
orouz wants to merge 1 commit into
Open
[Entity Store] Remove duplicate extraction error log to reduce alert noise#272047orouz wants to merge 1 commit into
orouz wants to merge 1 commit into
Conversation
orouz
added
release_note:skip
orouz
commented
May 31, 2026
| } | ||
|
|
||
| private async handleError(error: any, type: EntityType): Promise<ExtractedLogsSummary> { | ||
| this.logger.error(error); |
Contributor
Author
There was a problem hiding this comment.
this func already persist (SO) and returns an error, so it makes sense the consumer would decide what do with it. in runTask we do log it.
Contributor
💚 Build Succeeded
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
our alerting rule ends up counting the same error twice:
Logs extraction failed for host: Request timed out, took 30791msRequest timed out- this was removed in the PRthe rule fires if the count is
>= 3, and we had a bunch of messages with a count of4errors, after this PR, these shouldn't be sent anymore.note: didn't add an error log in the
force_log_extractionconsumer as it's for dev only anyway.