Skip to content

[Entity Store] Remove duplicate extraction error log to reduce alert noise #272047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orouz wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

[Entity Store] Remove duplicate extraction error log to reduce alert noise #272047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ons/security/plugins/entity_store/server/domain/logs_extraction/logs_extraction_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,8 +846,6 @@ export class LogsExtractionClient {
}

private async handleError(error: any, type: EntityType): Promise<ExtractedLogsSummary> {
this.logger.error(error);
Copy link
Copy Markdown
Contributor Author

@orouz orouz May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this func already persist (SO) and returns an error, so it makes sense the consumer would decide what do with it. in runTask we do log it.


if (
SavedObjectsErrorHelpers.isNotFoundError(error) ||
error instanceof EntityStoreNotRunningError
Expand Down
Loading