refactor: remove graceful-fs dependency
#228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use fsPromises from Node 22 instead
erikian
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Unless something's changed recently, there was a consensus in @electron/wg-ecosystem around using graceful-fs instead of Node's built-in fs when migrating our packages to Node 22 because IIRC it has better error handling in some specific edge cases; most packages were using fs-extra which uses graceful-fs under the hood, so we're actually cutting down on some dependencies by using graceful-fs directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the issue described in #227 and also removes our
graceful-fsdependency.