Skip to content

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 12, 2025

Takes over the responsibility for animating the workspace switch from the window manager. It also prepares for switching over multiple workspaces at once with one gesture.

This has multiple improvements:

  • Allow switching over multiple workspaces with one gesture (infrastructure in place, only requires new touchpad backend)
  • Allow interrupting a gesture (requires changes from MultitaskingView: Allow workspace switch animation to be interrupted #2161)
  • Allow interrupting keyboard shortcut animation
  • Allow to spam keyboard shortcuts (especially switch to next/previous ws) to quickly switch over multiple workspaces
  • Animate over all workspaces that are skipped (e.g. when triggering move to last ws shortcut)

Known issues:

@leolost2605 leolost2605 marked this pull request as ready for review January 13, 2025 22:04
@leolost2605
Copy link
Member Author

leolost2605 commented Jan 13, 2025

This is ready for testing and review now.
However it requires changes from #2195 and #2161 to fix some rare cases of unwanted behavior (e.g. the dock will always show up during switching, and one can stack the nudge infinitely) therefore

THIS IS NOT READY FOR MERGING YET (but since it's quite a big change that's pretty much in its final form testing and code review is already welcome :))

@lenemter lenemter added the Conflicts Has conflicts with the target branch label Jan 17, 2025
@leolost2605 leolost2605 removed the Conflicts Has conflicts with the target branch label Jan 19, 2025
@lenemter lenemter added the Conflicts Has conflicts with the target branch label Jan 26, 2025
@leolost2605 leolost2605 mentioned this pull request Feb 8, 2025
1 task
@leolost2605 leolost2605 deleted the leolost/desktop-workspace-switcher branch March 9, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Conflicts Has conflicts with the target branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants