-
-
Notifications
You must be signed in to change notification settings - Fork 77
Multitasking view desktop workspace switch #2291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…desktop-ws-switch
|
This should be ready for review and testing now :) |
lenemter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from 2 bugs I noticed:
- WindowClone's pointer events are broken. When switching workspaces I can see close button and tooltip, but in the multitasking view they're invisible.
pointer-bug.mp4
- Not a serious issue but some layer issues with windows 'Always on visible workspace' checked
pointer-bug.mp4
|
I can reproduce neither of these issues :/ Regarding the workspace closed am I doing something wrong? Kooha-2025-03-08-12-14-59.mp4And regarding the shortcuts issue: So you spam Super + s and Super + 1 and suddenly the multitasking view wont open/close again and you're stuck? Is there anything different that might help? |
|
Hm.. I can reproduce the issue in main as well. I'll report the issue separately |
|
@leolost2605 can you resolve the conflicts please :) |
|
@lenemter done :) |
|
I get crash when switching workspaces when animations are disabled: |
|
The crash should be fixed now :) |
lenemter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a new issue -- zoom animation is broken :/
|
@lenemter ah yeah that was because i upped the speed here for more amplitude for the nudge. I adjusted the values a bit more so it should work now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leolost2605 When I hold Super+Left/Right on desktop or in multitasking view the framerate drops. The same thing happens with Super+Plus/Minus and Super+Scroll with 'Zoom' action :/ I can't reproduce this issue in main
|
@lenemter ok a bug where you could "stack" the overshoot animation should be fixed now can you try again with that? If you still get frame drops can you maybe send a screen record and tell me your specs? |
|
Ok nvm starting our spring isn't that expensive lol |
lenemter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better but the small lag is still there when holding down the keys. But I can reproduce the same issue in main, so let's deal with it later.
|
Also, the lag may be caused by #2060 ¯\_(ツ)_/¯ |
|
Could you fix up |
Uses the multitasking view widgets for the desktop workspace switch.
We now have the blurred background for the desktop workspace switch as well.
Also windows that are always visible and thus shouldn't be shown in the multitasking view used to simply disappear. Now they are faded out.
This now also the all the improvements from the new gesture infrastructure:
Fixes #1202
Closes #2225