Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Mar 5, 2025

Screenshot from 2025-03-05 20 48 42

Fixes #1998

To do:

  • Figure out how to handle power saving (probably Granite and applications should handle that??)
  • Test with multiple monitors (doesn't make sense yet)
  • Test with display scaling
  • Fix X11 bug when window opens (probably will be fixed by Use pre configure mechanism for window positioning #2216)
  • Test with fractional scaling

@lenemter lenemter marked this pull request as ready for review March 6, 2025 09:52
@lenemter lenemter mentioned this pull request Mar 8, 2025
1 task
@lenemter lenemter requested a review from a team March 13, 2025 12:37
@lenemter lenemter marked this pull request as draft March 31, 2025 21:33
@lenemter lenemter force-pushed the lenemter/bg-blur-2 branch from b8668e6 to 09ea1f0 Compare July 28, 2025 10:38
@lenemter lenemter marked this pull request as ready for review July 28, 2025 10:39
@lenemter lenemter requested a review from danirabbit July 28, 2025 11:26
@danirabbit
Copy link
Member

Screenshot from 2025-07-28 13 05 48

I'm sure @leolost2605 has some more informed opinions about the UI, but from a design perspective I think it looks clean and is very legible :)

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good thank you!
I wonder though if we still want the left, right, top, bottom offsets or if we'd rather want to set the correct shadow size in gtk like it's done in the dock since elementary/dock#437 ?

@lenemter
Copy link
Member Author

lenemter commented Aug 3, 2025

@leolost2605 I initially tried this approach, but the problem is dock's bottom margin. If we set it as 'shadow' then there will be no margin. But if we set it as window content then the bottom margin will be blurred.

@lenemter lenemter force-pushed the lenemter/bg-blur-2 branch from a24e311 to 5c82521 Compare August 3, 2025 03:41
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leolost2605 I initially tried this approach, but the problem is dock's bottom margin. If we set it as 'shadow' then there will be no margin. But if we set it as window content then the bottom margin will be blurred.

Ah I guess we might want a margin property for the shell clients then similar to what wlr layer shell has.
But since it's private API anyways we can always change it later so LGTM :)

@danirabbit
Copy link
Member

@lenemter are you happy to merge this?

@lenemter
Copy link
Member Author

@danirabbit I'm happy with the gala part but not so much with the dock. We basically need to either hardcode bottom margin size or allow changing it via gsetting. There's probably a way to achieve this with clever CSS but I'm not ready to dig into it yet.

@lenemter lenemter merged commit 0035139 into main Sep 14, 2025
6 checks passed
@lenemter lenemter deleted the lenemter/bg-blur-2 branch September 14, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blur Behind

4 participants