Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Mar 9, 2025

@lenemter lenemter requested review from a team March 9, 2025 11:56
@lenemter lenemter added this to OS 9 Mar 12, 2025
@lenemter lenemter moved this to Needs Review in OS 9 Mar 12, 2025
@lenemter lenemter marked this pull request as ready for review March 12, 2025 19:46
@lenemter lenemter changed the title Add 'Open in Photos' to screenshot notification Add 'Open in Photo Viewer' to screenshot notification Mar 12, 2025
@lenemter
Copy link
Member Author

@danirabbit Fixed! I confirmed it uses translated app name as it should. But I encountered elementary/notifications#237 which makes it look very bad with Russian where "Open in Photo Viewer" is a very long line (33 symbols)

@lenemter lenemter added the Blocked Something else needs to be done before this can be fixed label Mar 20, 2025
@lenemter lenemter moved this from Needs Review to In progress in OS 9 Mar 20, 2025
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@danirabbit danirabbit merged commit 2f1786f into main Jun 3, 2025
4 of 5 checks passed
@danirabbit danirabbit deleted the lenemter/open-in-photos branch June 3, 2025 19:07
@github-project-automation github-project-automation bot moved this from In progress to Done in OS 9 Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked Something else needs to be done before this can be fixed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants