Skip to content

Add 'Open in Photo Viewer' to screenshot notification #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add 'Open in Photo Viewer' to screenshot notification #2299

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04628f6
Cleanup ScreenshotManager and WindowManager
lenemter Mar 9, 2025
6a0098e
Add 'Open in Photos' to screenshot notification
lenemter Mar 9, 2025
f6ff4e4
Merge branch 'main' into lenemter/open-in-photos
lenemter Mar 9, 2025
ed48cb5
Merge branch 'main' into lenemter/open-in-photos
lenemter Mar 12, 2025
1913744
Fix merge
lenemter Mar 12, 2025
71d6290
Don't hardcode application names
lenemter Mar 12, 2025
97ecfcd
Merge branch 'main' into lenemter/open-in-photos
lenemter Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions src/ScreenshotManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ public class Gala.ScreenshotManager : Object {
var show_in_files_action = new GLib.SimpleAction ("show-in-files", GLib.VariantType.STRING);
show_in_files_action.activate.connect (show_in_files);
notifications_manager.add_action (show_in_files_action);

var open_in_photos_action = new GLib.SimpleAction ("open-in-photos", GLib.VariantType.STRING);
open_in_photos_action.activate.connect (open_in_photos);
notifications_manager.add_action (open_in_photos_action);
}

[CCode (instance_pos = -1)]
Expand Down Expand Up @@ -133,8 +137,23 @@ public class Gala.ScreenshotManager : Object {

string[] actions = {};
if (!clipboard) {
/// TRANSLATORS: 'Files' is the name of file manager used by elementary OS
actions = { GLib.Action.print_detailed_name ("show-in-files", new Variant ("s", filename_used)), _("Show in Files") };
var files_appinfo = AppInfo.get_default_for_type ("inode/directory", true);
var photos_appinfo = AppInfo.get_default_for_type ("image/png", true);

actions = {
GLib.Action.print_detailed_name (
"show-in-files",
new Variant ("s", filename_used)),
/// TRANSLATORS: %s represents a name of file manager
_("Show in %s").printf (files_appinfo.get_display_name ()
),
GLib.Action.print_detailed_name (
"open-in-photos",
new Variant ("s", filename_used)),
/// TRANSLATORS: %s represents a name of image viewer
_("Open in %s").printf (photos_appinfo.get_display_name ()
)
};
}

notifications_manager.send.begin (
Expand All @@ -160,6 +179,19 @@ public class Gala.ScreenshotManager : Object {
}
}

private void open_in_photos (GLib.Variant? variant) requires (variant != null && variant.is_of_type (GLib.VariantType.STRING)) {
var files_list = new GLib.List<GLib.File> ();
files_list.append (GLib.File.new_for_path (variant.get_string ()));

var photos_appinfo = AppInfo.get_default_for_type ("image/png", true);

try {
photos_appinfo.launch (files_list, null);
} catch (Error e) {
warning (e.message);
}
}

public void flash_area (int x, int y, int width, int height) throws DBusError, IOError {
debug ("Flashing area");

Expand Down