Skip to content

Multitasking view: swipe up to close window #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 25, 2025

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Mar 23, 2025

Fixes #2199

2025-03-23.23-36-47.mp4
  • Figure out how not to block horizontal scroll

@lenemter lenemter requested a review from a team March 23, 2025 15:52
@lenemter lenemter marked this pull request as ready for review March 23, 2025 15:52
Copy link
Member

@wpkelso wpkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on the animation being like an an old TV turning off, where the window goes flat then collapses horizontally?

@danirabbit
Copy link
Member

In iPad OS you kind of throw them off screen:

ScreenRecording_03-23-2025.12-46-20_1.mp4

@danirabbit
Copy link
Member

Looks like Android is the same https://youtu.be/9KXsAANhh7g

but it looks like in Android you don’t need to swipe all the way up from the bottom of the screen off the top of the screen. At a certain threshold it just fades out. Which makes sense to me

@lenemter
Copy link
Member Author

@danirabbit does this look good to you?

2025-03-23.23-36-47.mp4

@danirabbit
Copy link
Member

@lenemter that looks amazing 😍

@wpkelso
Copy link
Member

wpkelso commented Mar 23, 2025

Does e8cc421 not just re-add the issue from #2199 ?

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great with trackpad, but on touch screen it looks like a window drag operation gets started when you try to swipe the window. I guess on touch screen we should only start a drag operation from the app icon to solve this?

When you start a swipe, the close button and tooltip fade out, which makes sense, but it's really slow. I also wonder should this stick to the window like the app icon does? It looks kind of weird for the close icon to get far away from the corner of the window

@lenemter
Copy link
Member Author

lenemter commented Mar 23, 2025

@wpkelso I suppose we want to block middle click to close window on anything other than mouse but allow swiping up with gestures instead, no?

@lenemter
Copy link
Member Author

@danirabbit touchscreen backend is not merged yet: #2096

@danirabbit
Copy link
Member

Oh my bad

@lenemter
Copy link
Member Author

lenemter commented Mar 24, 2025

@danirabbit Fixed and ready for review

leolost2605

This comment was marked as resolved.

@lenemter lenemter requested a review from leolost2605 March 24, 2025 20:19
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets gooo

@lenemter lenemter merged commit d9713d1 into main Mar 25, 2025
5 checks passed
@lenemter lenemter deleted the lenemter/window-close-with-swipe branch March 25, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swiping in the multitasking view can close applications
4 participants