-
-
Notifications
You must be signed in to change notification settings - Fork 77
Multitasking view: swipe up to close window #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on the animation being like an an old TV turning off, where the window goes flat then collapses horizontally?
In iPad OS you kind of throw them off screen: ScreenRecording_03-23-2025.12-46-20_1.mp4 |
Looks like Android is the same https://youtu.be/9KXsAANhh7g but it looks like in Android you don’t need to swipe all the way up from the bottom of the screen off the top of the screen. At a certain threshold it just fades out. Which makes sense to me |
@danirabbit does this look good to you? 2025-03-23.23-36-47.mp4 |
@lenemter that looks amazing 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great with trackpad, but on touch screen it looks like a window drag operation gets started when you try to swipe the window. I guess on touch screen we should only start a drag operation from the app icon to solve this?
When you start a swipe, the close button and tooltip fade out, which makes sense, but it's really slow. I also wonder should this stick to the window like the app icon does? It looks kind of weird for the close icon to get far away from the corner of the window
@wpkelso I suppose we want to block middle click to close window on anything other than mouse but allow swiping up with gestures instead, no? |
@danirabbit touchscreen backend is not merged yet: #2096 |
Oh my bad |
@danirabbit Fixed and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM lets gooo
Fixes #2199
2025-03-23.23-36-47.mp4