You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first commit now only allows opening the windowoverview with window ids (it was already deprecated and not used anywhere but the code was still in place) and therefore does a bunch of cleanup and fixes some visual bugs (e.g. when closing a window in the overview the destroy animation would play behind where the window is normally positioned).
The second commit includes some visual and ux changes:
all the windows that are shown are now raised so if you have two on a workspace but a window from another app above them and then select one (or no window) both will be on top now. This fixes some incosistencies where they animate back but then suddenly a third window appears in between them.
We don't hide other windows instead we are now on top (above the shell group) and just dim the whole background. This fixes some more incosistencies where other windows would just disappear and pop up again. Also the wingpanel and dock appeared interactable but weren't. It will now also make sense to show this while in the multitasking view (good for Initial support for keeping shellclients in the multitasking view #2275).
it was already deprecated and not used anywhere but the code was still in place
It is not, in fact, deprecated and is still used for the 'expose-all-windows' shortcut (Super+A), which shows windows from all workspaces. The multitasking view can't show all windows, so I guess we still need to keep the old window overview.
It is not, in fact, deprecated and is still used for the 'expose-all-windows' shortcut (Super+A), which shows windows from all workspaces. The multitasking view can't show all windows, so I guess we still need to keep the old window overview.
Huh since #485 was closed and I thought I'd remembered that in there I somewhere read that the expose all windows can be removed I thought this was deprecated. Seems like I was wrong 😅
I added the expose all windows back while keeping the cleanup and visual changes.
New windows that appear while open are now still just added behind because I think the semantics here is you have your set of windows and choose one and not managing windows (that's what the multitasking view is for) but if really wanted we can change it that they get added to the spread (though if we want to do that, then I'd like to do it in a follow up since it's kind of broken in main as well).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leolost2605
force-pushed
the
leolost/cleanup-window-overview
branch
2 times, most recently
from
The first commit
now only allows opening the windowoverview with window ids (it was already deprecated and not used anywhere but the code was still in place) and thereforedoes a bunch of cleanup and fixes some visual bugs (e.g. when closing a window in the overview the destroy animation would play behind where the window is normally positioned).The second commit includes some visual and ux changes:
Let me know what you think :)