Skip to content

Overlay window overview #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Overlay window overview #2350

wants to merge 2 commits into from

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Mar 29, 2025 •
edited
Loading

The first commit now only allows opening the windowoverview with window ids (it was already deprecated and not used anywhere but the code was still in place) and therefore does a bunch of cleanup and fixes some visual bugs (e.g. when closing a window in the overview the destroy animation would play behind where the window is normally positioned).

The second commit includes some visual and ux changes:

  • all the windows that are shown are now raised so if you have two on a workspace but a window from another app above them and then select one (or no window) both will be on top now. This fixes some incosistencies where they animate back but then suddenly a third window appears in between them.
  • We don't hide other windows instead we are now on top (above the shell group) and just dim the whole background. This fixes some more incosistencies where other windows would just disappear and pop up again. Also the wingpanel and dock appeared interactable but weren't. It will now also make sense to show this while in the multitasking view (good for Implement support for keeping shellclients in the multitasking view  #2275).

Let me know what you think :)

@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch 2 times, most recently from 3a8fe4a to 86e76d3 Compare March 29, 2025 14:55
@lenemter
Copy link
Member

lenemter commented Mar 29, 2025

it was already deprecated and not used anywhere but the code was still in place

It is not, in fact, deprecated and is still used for the 'expose-all-windows' shortcut (Super+A), which shows windows from all workspaces. The multitasking view can't show all windows, so I guess we still need to keep the old window overview.

@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch 2 times, most recently from e88aff5 to 666145c Compare April 5, 2025 11:20
@leolost2605
Copy link
Member Author

leolost2605 commented Apr 5, 2025

It is not, in fact, deprecated and is still used for the 'expose-all-windows' shortcut (Super+A), which shows windows from all workspaces. The multitasking view can't show all windows, so I guess we still need to keep the old window overview.

Huh since #485 was closed and I thought I'd remembered that in there I somewhere read that the expose all windows can be removed I thought this was deprecated. Seems like I was wrong 😅
I added the expose all windows back while keeping the cleanup and visual changes.
New windows that appear while open are now still just added behind because I think the semantics here is you have your set of windows and choose one and not managing windows (that's what the multitasking view is for) but if really wanted we can change it that they get added to the spread (though if we want to do that, then I'd like to do it in a follow up since it's kind of broken in main as well).

@leolost2605 leolost2605 requested review from a team April 5, 2025 11:24
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch 2 times, most recently from c5d7337 to 66e4852 Compare April 5, 2025 11:28
lenemter
lenemter reviewed Apr 16, 2025
View reviewed changes
@leolost2605 leolost2605 mentioned this pull request Jul 5, 2025
Merged
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch from 66e4852 to 0ac8173 Compare July 6, 2025 18:18
@leolost2605 leolost2605 requested review from a team and lenemter July 6, 2025 18:18
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch 3 times, most recently from fe6558f to 3ca29b6 Compare July 6, 2025 18:47
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch from b2e1f8b to 1f96cc5 Compare October 14, 2025 15:36
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch from 1f96cc5 to a384ac5 Compare November 1, 2025 17:50
@leolost2605 leolost2605 force-pushed the leolost/cleanup-window-overview branch from a384ac5 to 57ef836 Compare November 1, 2025 17:58
@leolost2605
Copy link
Member Author

leolost2605 commented Nov 1, 2025

Kooha-2025-11-01-19-02-35.mp4

@lenemter
Copy link
Member

lenemter commented Nov 1, 2025

I'm -1 on bringing all app windows to top. It just feels unexpected..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter Awaiting requested review from lenemter

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leolost2605 @lenemter