Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Jun 5, 2025

Fixes #1264

@lenemter lenemter requested review from a team and danirabbit June 5, 2025 16:43
@lenemter
Copy link
Member Author

lenemter commented Jun 5, 2025

@danirabbit should this follow our 'enable-hotcorners-in-fullscreen' setting or something? I guess this can be annoying in games

@danirabbit
Copy link
Member

@lenemter that makes sense to me

@lenemter lenemter force-pushed the lenemter/show-wingpanel-in-fullscreen branch from 8ec5f19 to f02e243 Compare June 9, 2025 16:00
@lenemter
Copy link
Member Author

lenemter commented Jun 9, 2025

Ready for review

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this makes the panel reveal when you press super, but I don't seem to be able to interact with it.

I can also reveal the dock with the mouse here, but I can't seem to be able to interact with it

@lenemter
Copy link
Member Author

@danirabbit I think this is X11 limitation unfortunately =( I'll remove this functionality for X session

@danirabbit
Copy link
Member

@lenemter I'm actually testing in Wayland session

@lenemter
Copy link
Member Author

@danirabbit Are you sure? I can't reproduce this issue in Wayland session. Please check the session in the Greeter. Saving last session was broken a while ago so you might have been using X11 accidentally

@lenemter
Copy link
Member Author

Ready for review (again)

@lenemter lenemter requested review from a team and danirabbit June 11, 2025 19:56
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected for me! Panel and dock reveals in fullscreen and can be interacted with, but only in Wayland

@danirabbit danirabbit merged commit 628eaa9 into main Jun 11, 2025
5 checks passed
@danirabbit danirabbit deleted the lenemter/show-wingpanel-in-fullscreen branch June 11, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applications menu opened but hidden in full screen mode

3 participants