Draw rounded rectangles using shader #2463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zeebok
approved these changes
Jul 14, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Code looks good! Might be a good idea to have UX pixel peep and ensure the radius matches?
Member
Author
|
I don't think this is necessary as in many cases (e.g. Tooltip) the border radius didn't align with our stylesheet |
leolost2605
reviewed
Jul 15, 2025
leolost2605
approved these changes
Jul 15, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Can't say much about the shader code and can't test right now but apart from that LGTM :) 🚀⚡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly optimizes our drawing code by using shader to draw rounded rectangles. Multitasking view gets a huge performance boost by not manually checking/drawing ActiveShape since it's now done on GPU.
The shaders code looks weird but I just couldn't make it produce consistent results. I played with offsets and this configuration gives the most symmetrical and sharp results