Skip to content

Conversation

@lenemter
Copy link
Member

For some reason window clone's has-pointer is bugged with disabled animations :(

@lenemter lenemter requested a review from a team November 15, 2025 09:38
@lenemter lenemter added this to A11y Nov 15, 2025
@lenemter lenemter moved this to Needs Review in A11y Nov 15, 2025
@leolost2605
Copy link
Member

I'm usually more in favor of fixing causes rather than symptoms but in this case I'm also thinking if we should just have the close button visible all the time anyways? The style guidelines discourage using hover for actual functionality. Maybe @danirabbit has an opinion here?

@danirabbit
Copy link
Member

@leolost2605 I think previously we left this as a hover effect since we have swipe-to-close on touch. But I think it would be fine to always show close buttons :)

@leolost2605
Copy link
Member

@danirabbit yeah that was my first thought too but afaict we don't have swipe to close on touch?

@danirabbit
Copy link
Member

@leolost2605 oh you're right because that's waiting on the touchscreen backend right? Either way, I'm +1 on showing close buttons all the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

4 participants