Skip to content

WindowClone: Fix has-pointer handling with reduced motion #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

WindowClone: Fix has-pointer handling with reduced motion #2641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Widgets/MultitaskingView/WindowClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ public class Gala.WindowClone : ActorTarget, RootTarget {
bind_property ("monitor-scale", active_shape, "monitor-scale");

clone_container = new Clutter.Actor () {
reactive = true,
pivot_point = { 0.5f, 0.5f }
};
clone_container.notify["has-pointer"].connect (update_hover_widgets);

window_title = new Tooltip (monitor_scale);
bind_property ("monitor-scale", window_title, "monitor-scale");
Expand All @@ -156,7 +158,6 @@ public class Gala.WindowClone : ActorTarget, RootTarget {
window.notify["title"].connect (() => window_title.set_text (window.get_title () ?? ""));
window_title.set_text (window.get_title () ?? "");

notify["has-pointer"].connect (update_hover_widgets);
notify["animating"].connect (update_hover_widgets);
}

Expand Down Expand Up @@ -373,7 +374,7 @@ public class Gala.WindowClone : ActorTarget, RootTarget {
private void update_hover_widgets () {
var duration = Utils.get_animation_duration (FADE_ANIMATION_DURATION);

var show = (has_pointer || close_button.has_pointer) && !animating;
var show = (clone_container.has_pointer || close_button.has_pointer) && !animating;

close_button.save_easing_state ();
close_button.set_easing_mode (Clutter.AnimationMode.LINEAR);
Expand Down
Loading