App setting to bypass do not disturb #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm gonna bump this to OS 7 because I think we need more careful consideration around the design here than we have this month |
|
This does work after restarting the notifications server. |
jeremypw
reviewed
Dec 10, 2021
| <schema id="io.elementary.notifications.applications"> | ||
| <key type="b" name="bypass-do-not-disturb"> | ||
| <default>false</default> | ||
| <summary>Notify despite Do Not Disturb is enabled</summary> |
There was a problem hiding this comment.
"Notify despite Do Not Disturb setting being enabled"
jeremypw
reviewed
Dec 10, 2021
| "/io/elementary/notifications/applications/%s/".printf (notification.app_id) | ||
| ); | ||
|
|
||
| if (!settings.get_boolean ("do-not-disturb") || app_settings.get_boolean ("bypass-do-not-disturb") || notification.priority == GLib.NotificationPriority.URGENT) { |
jeremypw
reviewed
Dec 10, 2021
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Couple of minor nitpicks re code but works as expected in conjunction with the other mentioned PR.
|
@marbetschar Are you able to address the review comments - this PR is nearly mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respects a user defined setting for a specific app to bypass do not disturb mode. Works together with the companion PR in the switchboard-plug-notifications repo: elementary/settings-notifications#84