Skip to content

App setting to bypass do not disturb #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

App setting to bypass do not disturb #148

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8affbf7
App setting to bypass do not disturb
marbetschar Aug 25, 2021
f517138
Merge branch 'master' into bypass-do-not-disturb
marbetschar Sep 22, 2021
9b6d978
Merge branch 'master' into bypass-do-not-disturb
marbetschar Oct 10, 2021
db9ac8d
Merge branch 'master' into bypass-do-not-disturb
Dec 10, 2021
683b875
Merge branch 'master' into bypass-do-not-disturb
Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data/notifications.gschema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
<child name="applications" schema="io.elementary.notifications.applications" />
</schema>
<schema id="io.elementary.notifications.applications">
<key type="b" name="bypass-do-not-disturb">
<default>false</default>
<summary>Notify despite Do Not Disturb is enabled</summary>
Copy link

@jeremypw jeremypw Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Notify despite Do Not Disturb setting being enabled"

</key>
<key type="b" name="ask">
<default>true</default>
<summary>Ask before allowing notifications</summary>
Expand Down
13 changes: 6 additions & 7 deletions src/DBus.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,13 @@ public class Notifications.Server : Object {
send_confirmation (app_icon, hints);
} else {
var notification = new Notifications.Notification (app_name, app_icon, summary, body, actions, hints);
var app_settings = new GLib.Settings.full (
SettingsSchemaSource.get_default ().lookup ("io.elementary.notifications.applications", true),
null,
"/io/elementary/notifications/applications/%s/".printf (notification.app_id)
);

if (!settings.get_boolean ("do-not-disturb") || notification.priority == GLib.NotificationPriority.URGENT) {
var app_settings = new GLib.Settings.full (
SettingsSchemaSource.get_default ().lookup ("io.elementary.notifications.applications", true),
null,
"/io/elementary/notifications/applications/%s/".printf (notification.app_id)
);

if (!settings.get_boolean ("do-not-disturb") || app_settings.get_boolean ("bypass-do-not-disturb") || notification.priority == GLib.NotificationPriority.URGENT) {
Copy link

@jeremypw jeremypw Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long line

if (app_settings.get_boolean ("bubbles")) {
if (bubbles.has_key (id) && bubbles[id] != null) {
bubbles[id].replace (notification);
Expand Down